Skip to content

test(filechooser): allow exact one second lastModified rounding - #42145

Open
dcrousso wants to merge 1 commit into
microsoft:mainfrom
dcrousso:fix-WebKit-setInputFiles-lastModified
Open

test(filechooser): allow exact one second lastModified rounding#42145
dcrousso wants to merge 1 commit into
microsoft:mainfrom
dcrousso:fix-WebKit-setInputFiles-lastModified

Conversation

@dcrousso

@dcrousso dcrousso commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

WebKit can round a millisecond timestamp down by exactly one second

for example, https://github.com/microsoft/playwright-browsers/actions/runs/31034589073/job/92422156152

WebKit can round a millisecond timestamp down by exactly one second
@dcrousso
dcrousso requested a review from yury-s August 5, 2026 22:25
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:699 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:211 › should intercept service worker requests (main and within) `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context @smoke `@realtime-time-library-chromium-linux`
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:807 › run-server › should upload a folder `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/heap.spec.ts:223 › should not leak workers `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:714 › run-server › should record trace with sources `@webkit-ubuntu-22.04-node20`

51229 passed, 1190 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [firefox] › mcp/cli-core.spec.ts:77 › click with --modifiers @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-devtools.spec.ts:84 › request shows full request and response details @mcp-windows-latest-firefox

8048 passed, 1284 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🟢 CI is clear — both failures are pre-existing flakes

Hi, I'm the Playwright bot and I took a first look at the failing CI here.

This PR is test-only (relaxing the lastModified rounding assertion from < 1000 to <= 1000 in three filechooser specs). The two failures are both Firefox MCP tests on Windows that have nothing to do with that diff, and both fail on unrelated SHAs, so I'm calling this green.

Details

Overall: The "tests 1" report has no failures — 8 flaky, nothing to triage. The MCP report has 2 failed, both on mcp-windows-latest-firefox, both proven pre-existing flakes. Nothing the diff touches (the setInputFiles lastModified assertion) is exercised by these MCP click/request tests.

Pre-existing flake / infra

Both are Firefox-only, Windows-only sporadic failures on code this PR doesn't touch.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant