Skip to content

fix(cli): rewrite CLI command in installed skills - #42137

Open
Skn0tt wants to merge 1 commit into
microsoft:mainfrom
Skn0tt:skn0tt-skills-cli-command-templating
Open

fix(cli): rewrite CLI command in installed skills#42137
Skn0tt wants to merge 1 commit into
microsoft:mainfrom
Skn0tt:skn0tt-skills-cli-command-templating

Conversation

@Skn0tt

@Skn0tt Skn0tt commented Aug 5, 2026

Copy link
Copy Markdown
Member

When skills are installed through npx/yarn/pnpm playwright cli (or init-skills), the examples still said playwright-cli, which isn't on PATH after 1.62. Sources keep the bare name so GitHub search still finds them; install rewrites the command to the invoker's package-manager form and leaves skill name, allowed-tools, and .playwright-cli/ alone.

Fixes #42135

Skills still document `playwright-cli`, which is fine for GitHub
search, but when installed via `npx/yarn/pnpm playwright cli` the
examples need the package-manager form. Rewrite at install time and
leave skill name / allowed-tools / `.playwright-cli/` alone.

Fixes: microsoft#42135

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f3c49995-a324-4711-b5b6-d4fe2f766e2d
@Skn0tt
Skn0tt requested a review from yury-s August 5, 2026 12:48
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-devtools.spec.ts:173 › response-body returns just the body @mcp-windows-latest-firefox

8062 passed, 1284 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🟢 The one failure is a pre-existing Firefox flake, unrelated to this PR

Hi, I'm the Playwright bot and I took a look at the CI failure.

The single failure — [firefox] › mcp/cli-devtools.spec.ts:173 › response-body returns just the body on mcp-windows-latest-firefox — is a pre-existing flake, not something this PR caused. This PR only rewrites the CLI command embedded in installed skills; it doesn't touch the devtools/response-body path the test exercises. The PR looks clear.

Details

Overall: one failed test in the merged MCP report, Firefox-Windows only. Nothing in the diff reaches it.

Pre-existing flake / infra

  • [firefox] › mcp/cli-devtools.spec.ts:173 › response-body returns just the body (@mcp-windows-latest-firefox) — flake. Across the test-results DB this test fails only on the mcp-windows-latest-firefox bot, and it does so on SHAs this PR can't be responsible for:

    On that bot the test is 395 passed / 4 failed (~1%), and it passes on every other project (chromium, chrome, msedge, webkit: 0 failures). The PR's changes are confined to CLI skill installation (installSkills.ts, cli-client/cli-daemon program.ts, SKILL.md), which the response-body devtools flow doesn't touch. No retries in this run, so it showed red rather than being rescued — but the history says flake.

Triaged by the Playwright bot - agent run

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context @smoke `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1469 › should update highlight when typing snapshot `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:299 › should report intercepted service worker requests in HAR `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:827 › should update state on subsequent run `@windows-latest-node22`

51229 passed, 1190 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: When CLI was installed along with 1.62, newly installed skills still reference playwright-cli instead of npx playwright cli

1 participant