fix(mcp): only enable /killkillkill under test - #42133
Open
Skn0tt wants to merge 1 commit into
Open
Conversation
Fixes: microsoft#42129 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bcb5b8bb-90b5-4bc9-baae-64ab11a9c665
Contributor
Test results for "MCP"1 failed 8049 passed, 1284 skipped Merge workflow run. |
Contributor
|
Hi, I'm the Playwright bot and I took a first look at the CI failures. 🟢 The one failure is a pre-existing flake — this PR is clear
DetailsOverall: one failed test, no real failures caused by this PR. Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/killkillkillwas only meant for our graceful-SIGINT test (Windows can't do that viaSIGTERM). Anyone who could reach the HTTP port could still trip it with the fixed header.Gate it on
isUnderTest()so production MCP HTTP servers don't expose it.Fixes #42129