feat(driver-bundle): split driver per platform and auto-select host#1935
Open
yury-s wants to merge 2 commits into
Open
feat(driver-bundle): split driver per platform and auto-select host#1935yury-s wants to merge 2 commits into
yury-s wants to merge 2 commits into
Conversation
Replace the single ~194MB driver-bundle (all platforms) with one artifact per platform: driver-bundle-mac-x64, driver-bundle-mac-arm64, driver-bundle-linux-x64, driver-bundle-linux-arm64 and driver-bundle-win-x64. driver-bundle now ships only DriverJar and uses OS-activated Maven profiles to pull in the matching platform artifact for the build host, so a Maven build resolves just the driver it needs with no extra configuration. driver-bundle-all aggregates every platform for cross-platform fat jars. Fixes: microsoft#1196
Explain that Maven auto-selects the host platform driver, how to bundle every platform with driver-bundle-all, and that Gradle consumers must declare the driver explicitly because Gradle ignores Maven POM profiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
driver-bundle(~194MB, all platforms) into per-platform artifacts:driver-bundle-mac-x64,-mac-arm64,-linux-x64,-linux-arm64,-win-x64.driver-bundlenow ships onlyDriverJarand uses OS-activated Maven profiles to pull the host platform's artifact automatically — Maven users get just their platform's driver with no extra config (a Linux x64 build pulls ~45MB instead of ~194MB).driver-bundle-allaggregates every platform for cross-platform fat jars (used bytest-cli-fatjar).Notes for review
driver-bundle-allfor a cross-platform jar.driver-bundle-allor a specificdriver-bundle-<platform>). Worth documenting if we take this approach.Fixes #1196