Reject plain-text helper results in composers instead of silently turning them into SQL#164
Open
Copilot wants to merge 2 commits into
Open
Reject plain-text helper results in composers instead of silently turning them into SQL#164Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/microsoft/pg_durable/sessions/7623efa8-a8d8-42a0-9d49-de2df8311dda Co-authored-by: pinodeca <32303022+pinodeca@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix df.wait_for_completion to return future envelope instead of plain text
Reject plain-text helper results in composers instead of silently turning them into SQL
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
df.wait_for_completion()returns plain text status, but composers (df.seq,df.join,df.race, etc.) were treating that text as SQL and baking values likecompletedinto the graph. The result was silent graph corruption and downstream syntax errors with no indication that the real problem was a non-future argument.Add composer-level shape validation
df.seq,df.as,df.loop,df.if,df.if_rows,df.join,df.join3,df.race, anddf.start.Fail early with actionable errors
SQLnodes.df.sql(...)vs. a wait primitive).Close the already-wrapped/operator path
SQLnodes whose payload is plain text rather than a SQL statement.Clarify
wait_for_completionsemanticsAdd focused coverage
Example of the new failure mode:
Now fails at composition time with an explicit shape error instead of producing a graph that later tries to execute
completedas SQL.