Skip to content

chore: add comparison of plurality to infinity_pool#581

Open
geeknoid wants to merge 2 commits into
mainfrom
multi
Open

chore: add comparison of plurality to infinity_pool#581
geeknoid wants to merge 2 commits into
mainfrom
multi

Conversation

@geeknoid

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 15, 2026 16:04
@geeknoid geeknoid enabled auto-merge (squash) July 15, 2026 16:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the plurality crate’s ecosystem/performance comparison materials by adding infinity_pool to the documented capability matrix and to the Linux-only cross-crate benchmarking + perf report generation flow.

Changes:

  • Add infinity-pool to the crate-level comparison table (both rustdoc in src/lib.rs and the generated README.md).
  • Extend the pool_comparison gungraun benchmark suite with infinity_pool::PinnedPool and infinity_pool::RawPinnedPool, and teach the perf report script to label these results.
  • Refresh docs/PERF.md to include the new comparison rows and updated benchmark numbers.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/plurality/src/lib.rs Adds infinity-pool to the rustdoc capability comparison table and link references.
crates/plurality/scripts/perf_report.rs Extends comparison label mapping to include the new infinity_* benchmark functions in the generated report.
crates/plurality/README.md Updates the generated README to include infinity-pool in the comparison table and link targets.
crates/plurality/docs/PERF.md Refreshes performance report output with updated numbers and new infinity-pool comparison rows.
crates/plurality/Cargo.toml Adds infinity_pool as a Linux-only dev-dependency for the gungraun comparison bench.
crates/plurality/benches/pool_comparison/linux.rs Adds PinnedPool and RawPinnedPool benchmark implementations and includes them in the benchmark group.
Cargo.lock Records the new infinity_pool dependency in the lockfile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings July 15, 2026 19:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (0107169) to head (7e0ed64).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         360      360           
  Lines       27886    27886           
=======================================
  Hits        27886    27886           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants