Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the plurality crate’s ecosystem/performance comparison materials by adding infinity_pool to the documented capability matrix and to the Linux-only cross-crate benchmarking + perf report generation flow.
Changes:
- Add
infinity-poolto the crate-level comparison table (both rustdoc insrc/lib.rsand the generatedREADME.md). - Extend the
pool_comparisongungraun benchmark suite withinfinity_pool::PinnedPoolandinfinity_pool::RawPinnedPool, and teach the perf report script to label these results. - Refresh
docs/PERF.mdto include the new comparison rows and updated benchmark numbers.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/plurality/src/lib.rs | Adds infinity-pool to the rustdoc capability comparison table and link references. |
| crates/plurality/scripts/perf_report.rs | Extends comparison label mapping to include the new infinity_* benchmark functions in the generated report. |
| crates/plurality/README.md | Updates the generated README to include infinity-pool in the comparison table and link targets. |
| crates/plurality/docs/PERF.md | Refreshes performance report output with updated numbers and new infinity-pool comparison rows. |
| crates/plurality/Cargo.toml | Adds infinity_pool as a Linux-only dev-dependency for the gungraun comparison bench. |
| crates/plurality/benches/pool_comparison/linux.rs | Adds PinnedPool and RawPinnedPool benchmark implementations and includes them in the benchmark group. |
| Cargo.lock | Records the new infinity_pool dependency in the lockfile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 360 360
Lines 27886 27886
=======================================
Hits 27886 27886 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
psandana
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.