Add back inliner to version converter#2813
Open
titaiwangms wants to merge 1 commit intomicrosoft:mainfrom
Open
Add back inliner to version converter#2813titaiwangms wants to merge 1 commit intomicrosoft:mainfrom
titaiwangms wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2813 +/- ##
==========================================
- Coverage 70.52% 70.39% -0.13%
==========================================
Files 228 228
Lines 27135 27140 +5
Branches 2727 2727
==========================================
- Hits 19137 19106 -31
- Misses 7065 7097 +32
- Partials 933 937 +4 ☔ View full report in Codecov by Sentry. |
Collaborator
|
What’s missing? Any new errors? |
Contributor
Author
#2812 torchlib onnx function. 40/200 models fail on benchmark. |
justinchuby
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, version converter only supports inlined model. In terms of torch onnx exporter, we should just remind/warn users that if their models includes local-function. We just don't support it.
series of version converter PRs:
#2791 (Removed assertion of no local function included)
#2799 (Missing opset import)
#2806 (Raise for RefAttr)
Maybe we should just try revert #2791?
cc @gramalingam @justinchuby