Initial builder

[gramalingam]

No description provided.

[github-advanced-security]

lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

[codecov]

Codecov Report

❌ Patch coverage is 81.58508% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.69%. Comparing base (d83d50b) to head (145afc2).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
onnxscript/_internal/builder.py	67.66%	43 Missing and 11 partials ⚠️
onnxscript/_internal/_inference.py	62.26%	15 Missing and 5 partials ⚠️
onnxscript/_internal/builder_test.py	97.60%	2 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2808      +/-   ##
==========================================
+ Coverage   70.52%   70.69%   +0.17%     
==========================================
  Files         228      231       +3     
  Lines       27135    27564     +429     
  Branches     2727     2776      +49     
==========================================
+ Hits        19137    19487     +350     
- Misses       7065     7125      +60     
- Partials      933      952      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

In general, for an unused local variable whose assignment has side effects, keep the expression (to preserve side effects) but drop or rename the unused binding. Here, the call to op.AnotherOp must remain so that the third node is added to the graph, but we do not need to store its result.

The best minimal fix without changing functionality is to remove the t3 = part and just call op.AnotherOp(t2, x, _domain="com.custom") as a standalone statement. This preserves the graph mutation while eliminating the unused variable. No imports, helper methods, or additional definitions are needed, and no other lines in the file require modification.

In general, to fix an unused local variable where the right-hand side has side effects, you should keep the expression call and remove only the binding of its result, or rename the variable to an “unused” name if you want to explicitly mark it as intentionally unused. Here, the right-hand side ms_op.AnotherOp(t1, x) clearly has the desired side effect of adding a node to op.builder.graph, and the variable t2 is never subsequently used.

The best minimal fix without changing functionality is to drop the assignment and just call the method. In onnxscript/_internal/builder_test.py, within test_opset_builder_for_custom_domain, change line 351 from t2 = ms_op.AnotherOp(t1, x) to ms_op.AnotherOp(t1, x). No new imports or helper methods are required, and no other lines in this file need to be touched.

In general, to fix an unused local variable whose right-hand side has important side effects, you keep the expression but either remove the left-hand side entirely (if syntax allows) or bind it to a name that clearly indicates it is intentionally unused (such as _ or a name containing unused). This preserves behavior while silencing the warning and clarifying intent.

Here, we should not remove the op.Mul(t2, x) call, because its side effect (adding a node to the graph) is required for the later assertions about nodes[2]. The simplest, non-disruptive change is to rename t3 to _ on line 379. That makes it explicit that the result value is not used while leaving test logic unchanged. No imports or further definitions are required, and only that single line in onnxscript/_internal/builder_test.py needs modification.

[gramalingam]

Hmmm ... interesting, I don't remember creating this PR (as it is still WIP) ...