Skip to content

Improve names of .node files #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bashamega wants to merge 14 commits into
base: main
Choose a base branch
from
+6 −6
Open

Improve names of .node files #768

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c9191b8
Rename conpty.cc to conpty_backend.cc
Bashamega Mar 14, 2025
14219fd
Rename winpty.cc to winpty_backend.cc
Bashamega Mar 14, 2025
6a5f6cd
patch:file name
Bashamega Mar 14, 2025
0b03874
Update binding.gyp
Bashamega Mar 14, 2025
8e7be77
Update binding.gyp
Bashamega Mar 14, 2025
92e4bb1
Update windowsPtyAgent.ts
Bashamega Mar 14, 2025
07e161b
chore: revert file name change
Bashamega Mar 15, 2025
d252340
chore: fix post install
Bashamega Mar 15, 2025
c42caca
-
Bashamega Mar 15, 2025
5402d97
-
Bashamega Mar 15, 2025
503b113
Update post-install.js
Bashamega Mar 17, 2025
407dc48
Merge branch 'main' into Bashamega-patch-1
Bashamega Mar 17, 2025
519a8ae
Update conpty.cc
Bashamega Mar 18, 2025
41b5881
Merge branch 'main' into Bashamega-patch-1
Bashamega Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
['OS=="win"', {
'targets': [
{
'target_name': 'conpty',
'target_name': 'conpty_backend',
'sources' : [
'src/win/conpty.cc',
'src/win/path_util.cc'
Expand Down
8 changes: 4 additions & 4 deletions scripts/post-install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ const path = require('path');

const RELEASE_DIR = path.join(__dirname, '../build/Release');
const BUILD_FILES = [
path.join(RELEASE_DIR, 'conpty.node'),
path.join(RELEASE_DIR, 'conpty.pdb'),
path.join(RELEASE_DIR, 'conpty_backend.node'),
path.join(RELEASE_DIR, 'conpty_backend.pdb'),
path.join(RELEASE_DIR, 'conpty_console_list.node'),
path.join(RELEASE_DIR, 'conpty_console_list.pdb'),
path.join(RELEASE_DIR, 'pty.node'),
Expand Down Expand Up @@ -66,9 +66,9 @@ if (os.platform() !== 'win32') {
const versionFolder = fs.readdirSync(CONPTY_DIR)[0];
console.log(` Found version ${versionFolder}`);
const sourceFolder = path.join(CONPTY_DIR, versionFolder, `win10-${windowsArch}`);
const destFolder = path.join(RELEASE_DIR, 'conpty');
const destFolder = path.join(RELEASE_DIR, 'conpty_backend');
fs.mkdirSync(destFolder, { recursive: true });
for (const file of ['conpty.dll', 'OpenConsole.exe']) {
Comment on lines -69 to -71
Copy link
Copy Markdown
Contributor

@deepak1556 deepak1556 Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should not be renamed, they are prebuilt binaries from conpty library.

for (const file of ['conpty_backend.dll', 'OpenConsole.exe']) {
const sourceFile = path.join(sourceFolder, file);
const destFile = path.join(destFolder, file);
console.log(` Copying ${sourceFile} -> ${destFile}`);
Expand Down
4 changes: 2 additions & 2 deletions src/windowsPtyAgent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ export class WindowsPtyAgent {
if (this._useConpty) {
if (!conptyNative) {
try {
conptyNative = require('../build/Release/conpty.node');
conptyNative = require('../build/Release/conpty_backend.node');
} catch (outerError) {
try {
conptyNative = require('../build/Debug/conpty.node');
conptyNative = require('../build/Debug/conpty_backend.node');
} catch (innerError) {
console.error('innerError', innerError);
// Re-throw the exception from the Release require if the Debug require fails as well
Expand Down