Skip to content

Fix TS generator crash from duplicated reference assemblies #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasongin merged 1 commit into from
Jan 15, 2026
+4 −0

Fix TS generator crash from duplicated reference assemblies

5da4202
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix TS generator crash from duplicated reference assemblies #469

Fix TS generator crash from duplicated reference assemblies
5da4202
Select commit
Loading
Failed to load commit list.
GitHub Actions / test results (macos-latest, net9.0, node22.x, Release) succeeded Jan 15, 2026 in 3s

134 passed, 0 failed and 0 skipped

Tests passed successfully

✅ test/net9.0-node22.x-Release/_sat12-bq155-ee26c0c8-8b0d-42f7-bb85-6552870536e9-726C535922FC_2026-01-15_17_54_59.trx

134 tests were completed in 159s with 134 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Microsoft.JavaScript.NodeApi.Test.GCTests 2✅ 299ms
Microsoft.JavaScript.NodeApi.Test.HostedClrTests 37✅ 32s
Microsoft.JavaScript.NodeApi.Test.JSProjectTests 8✅ 89s
Microsoft.JavaScript.NodeApi.Test.JSReferenceTests 7✅ 6ms
Microsoft.JavaScript.NodeApi.Test.JSValueScopeTests 19✅ 10ms
Microsoft.JavaScript.NodeApi.Test.NativeAotTests 32✅ 35s
Microsoft.JavaScript.NodeApi.Test.NodejsEmbeddingTests 18✅ 1s
Microsoft.JavaScript.NodeApi.Test.TypeDefsGeneratorTests 11✅ 38ms

✅ Microsoft.JavaScript.NodeApi.Test.GCTests

✅ GCHandles
✅ GCObjects

✅ Microsoft.JavaScript.NodeApi.Test.HostedClrTests

✅ Test(id: "edgejs-perf/measure-latency")
✅ Test(id: "napi-dotnet-init/custom_export")
✅ Test(id: "napi-dotnet-init/custom_init")
✅ Test(id: "napi-dotnet/async_methods")
✅ Test(id: "napi-dotnet/collections")
✅ Test(id: "napi-dotnet/complex_types")
✅ Test(id: "napi-dotnet/delegates")
✅ Test(id: "napi-dotnet/dynamic_extensions")
✅ Test(id: "napi-dotnet/dynamic_generics")
✅ Test(id: "napi-dotnet/dynamic_invoke")
✅ Test(id: "napi-dotnet/dynamic_no_namespace_type")
✅ Test(id: "napi-dotnet/dynamic_optional_params")
✅ Test(id: "napi-dotnet/errors")
✅ Test(id: "napi-dotnet/hello")
✅ Test(id: "napi-dotnet/jsvalue_cast")
✅ Test(id: "napi-dotnet/module_class")
✅ Test(id: "napi-dotnet/multi_instance")
✅ Test(id: "napi-dotnet/object_map")
✅ Test(id: "napi-dotnet/overloads")
✅ Test(id: "napi-dotnet/streams")
✅ Test(id: "napi-dotnet/subclass")
✅ Test(id: "napi-dotnet/thread_safety")
✅ Test(id: "node-addon-api/basic_types/array")
✅ Test(id: "node-addon-api/basic_types/boolean")
✅ Test(id: "node-addon-api/basic_types/number")
✅ Test(id: "node-addon-api/basic_types/value")
✅ Test(id: "node-addon-api/bigint")
✅ Test(id: "node-addon-api/object/delete_property")
✅ Test(id: "node-addon-api/object/finalizer")
✅ Test(id: "node-addon-api/object/get_property")
✅ Test(id: "node-addon-api/object/has_own_property")
✅ Test(id: "node-addon-api/object/has_property")
✅ Test(id: "node-addon-api/object/object_freeze_seal")
✅ Test(id: "node-addon-api/object/object")
✅ Test(id: "node-addon-api/object/set_property")
✅ Test(id: "node-addon-api/object/subscript_operator")
✅ Test(id: "node-addon-api/testUtil")

✅ Microsoft.JavaScript.NodeApi.Test.JSProjectTests

✅ Test(id: "projects/js-cjs-dynamic/net9.0")
✅ Test(id: "projects/js-cjs-module/test")
✅ Test(id: "projects/js-esm-dynamic/net9.0")
✅ Test(id: "projects/js-esm-module/test")
✅ Test(id: "projects/ts-cjs-dynamic/net9.0")
✅ Test(id: "projects/ts-cjs-module/test")
✅ Test(id: "projects/ts-esm-dynamic/net9.0")
✅ Test(id: "projects/ts-esm-module/test")

✅ Microsoft.JavaScript.NodeApi.Test.JSReferenceTests

✅ GetReferenceFromDifferentRootScope
✅ GetReferenceFromDifferentThread
✅ GetReferenceFromParentScope
✅ GetReferenceFromSameScope
✅ GetWeakReferenceUnavailable
✅ TryGetWeakReferenceUnavailable
✅ TryGetWeakReferenceValue

✅ Microsoft.JavaScript.NodeApi.Test.JSValueScopeTests

✅ AccessPropertyKeyFromClosedScope
✅ AccessValueFromClosedScope
✅ AccessValueFromDifferentRootScope
✅ AccessValueFromDifferentThread
✅ CreateCallbackScope
✅ CreateEscapableScopeWithinCallback
✅ CreateHandleScopeWithinCallback
✅ CreateHandleScopeWithinModule
✅ CreateHandleScopeWithinRoot
✅ CreateModuleScopeWithinNoContextScope
✅ CreateModuleScopeWithinRootScope
✅ CreateModuleScopeWithoutRoot
✅ CreateNoContextScope
✅ CreateRootScope
✅ CreateValueFromDifferentThread
✅ InvalidCallbackContextScopeNesting
✅ InvalidModuleContextScopeNesting
✅ InvalidNoContextScopeNesting
✅ InvalidRootContextScopeNesting

✅ Microsoft.JavaScript.NodeApi.Test.NativeAotTests

✅ Test(id: "edgejs-perf/measure-latency")
✅ Test(id: "napi-dotnet-init/custom_export")
✅ Test(id: "napi-dotnet-init/custom_init")
✅ Test(id: "napi-dotnet/async_methods")
✅ Test(id: "napi-dotnet/collections")
✅ Test(id: "napi-dotnet/complex_types")
✅ Test(id: "napi-dotnet/delegates")
✅ Test(id: "napi-dotnet/errors")
✅ Test(id: "napi-dotnet/hello")
✅ Test(id: "napi-dotnet/jsvalue_cast")
✅ Test(id: "napi-dotnet/module_class")
✅ Test(id: "napi-dotnet/multi_instance")
✅ Test(id: "napi-dotnet/object_map")
✅ Test(id: "napi-dotnet/overloads")
✅ Test(id: "napi-dotnet/streams")
✅ Test(id: "napi-dotnet/subclass")
✅ Test(id: "napi-dotnet/thread_safety")
✅ Test(id: "node-addon-api/basic_types/array")
✅ Test(id: "node-addon-api/basic_types/boolean")
✅ Test(id: "node-addon-api/basic_types/number")
✅ Test(id: "node-addon-api/basic_types/value")
✅ Test(id: "node-addon-api/bigint")
✅ Test(id: "node-addon-api/object/delete_property")
✅ Test(id: "node-addon-api/object/finalizer")
✅ Test(id: "node-addon-api/object/get_property")
✅ Test(id: "node-addon-api/object/has_own_property")
✅ Test(id: "node-addon-api/object/has_property")
✅ Test(id: "node-addon-api/object/object_freeze_seal")
✅ Test(id: "node-addon-api/object/object")
✅ Test(id: "node-addon-api/object/set_property")
✅ Test(id: "node-addon-api/object/subscript_operator")
✅ Test(id: "node-addon-api/testUtil")

✅ Microsoft.JavaScript.NodeApi.Test.NodejsEmbeddingTests

✅ CallFunction
✅ ErrorPropagation
✅ ImportBuiltinModule
✅ ImportCommonJSModule
✅ ImportCommonJSPackage
✅ ImportESModule
✅ ImportESPackage
✅ LoadMainScriptNoThread
✅ LoadMainScriptWithThread
✅ MarshalClass
✅ RestartEnvironment
✅ StartEnvironment
✅ UnhandledRejection
✅ WorkerArgs
✅ WorkerEnv
✅ WorkerIsMainThread
✅ WorkerMessages
✅ WorkerStdinStdout

✅ Microsoft.JavaScript.NodeApi.Test.TypeDefsGeneratorTests

✅ GenerateEnum
✅ GenerateExtensionMethods
✅ GenerateGenericClass
✅ GenerateGenericDelegate
✅ GenerateGenericInterface
✅ GenerateJSDocLink
✅ GenerateSimpleClass
✅ GenerateSimpleDelegate
✅ GenerateSimpleInterface
✅ GenerateSimpleMethod
✅ GenerateSimpleProperty
View more details on GitHub Actions