TEST: Fix _bulkcopy kwargs passing to mssql_py_core #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rust API expects kwargs as a dict parameter (kwargs=dict), not as Python keyword arguments (**kwargs). Before: pycore_cursor.bulkcopy(table_name, iter(data), **kwargs) After: pycore_cursor.bulkcopy(table_name, iter(data), kwargs=kwargs)
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.row.py: 66.2%
mssql_python.pybind.ddbc_bindings.cpp: 69.4%
mssql_python.pybind.ddbc_bindings.h: 69.7%
mssql_python.pybind.connection.connection.cpp: 73.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 84.1%
mssql_python.cursor.py: 84.7%🔗 Quick Links
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mssql-py-core API expects kwargs as a dict parameter (kwargs=dict), not as Python keyword arguments (**kwargs).
Before: pycore_cursor.bulkcopy(table_name, iter(data), **kwargs)
After: pycore_cursor.bulkcopy(table_name, iter(data), kwargs=kwargs)
Work Item / Issue Reference
Summary
This pull request updates the way keyword arguments are passed to the
bulkcopymethod in themssql_python/cursor.pyfile. The main change ensures compatibility with the Rust API by passingkwargsas a dictionary parameter rather than as Python keyword arguments.pycore_cursor.bulkcopyto passkwargsas a dictionary using thekwargsparameter, aligning with the expectations of the Rust API.