FEAT: Modernize build system with pyproject.toml and custom build backend #408
+618
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add build_ddbc package for native extension compilation - python -m build_ddbc: standalone compilation CLI - Custom PEP 517 backend: auto-compiles on python -m build - Consolidate project config into pyproject.toml - Moved pytest config from pytest.ini - Added optional dependencies [dev], [lint], [all] - Added coverage, mypy, black, autopep8, pylint configs - Simplified setup.py to platform-specific wheel logic only - Delete pytest.ini (moved to pyproject.toml)
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.row.py: 66.2%
mssql_python.pybind.ddbc_bindings.cpp: 69.4%
mssql_python.pybind.ddbc_bindings.h: 69.7%
mssql_python.pybind.connection.connection.cpp: 73.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 84.1%
mssql_python.cursor.py: 84.7%🔗 Quick Links
|
|
It seems this lacks build support for FreeBSD, which would be necessary for my organization to use this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request introduces a new build system for the
mssql-pythonpackage, centering around a custombuild_ddbcpackage that provides both a command-line interface and a PEP 517-compliant build backend. The changes automate the compilation of theddbc_bindingsnative extension, streamline build configuration, and modernize project metadata and tooling configuration.The most important changes are:
Build System Overhaul:
Added the
build_ddbcpackage, which includes a CLI (python -m build_ddbc) for compiling native extensions and a PEP 517 build backend that automatically compilesddbc_bindingsbefore building wheels or during editable installs. This includes new modules:__init__.py,__main__.py,compiler.py, andbuild_backend.py. [1] [2] [3] [4]Updated
pyproject.tomlto use the newbuild_ddbc.build_backendas the build backend, specify build requirements, and comprehensively define project metadata, dependencies, and URLs.Tooling and Linting Configuration:
pyproject.toml, including sections for Black, Autopep8, Pylint, Flake8, and MyPy, with appropriate options for each tool. [1] [2] [3]Test Configuration Cleanup:
pytest.inifile, consolidating test markers and options intopyproject.tomlfor a unified configuration.These changes collectively modernize the build and development workflow for the project, making it easier to build, test, and maintain native extensions and Python code.