Skip to content

Conversation

@bewithgaurav
Copy link
Collaborator

Work Item / Issue Reference

AB#<WORK_ITEM_ID>

GitHub Issue: #<ISSUE_NUMBER>


Summary

This pull request removes unused helper functions related to connection string manipulation from the mssql_python.helpers module. The primary focus is on cleaning up the codebase by eliminating the add_driver_to_connection_str and add_driver_name_to_app_parameter functions, as well as their import and usage.

Code cleanup and removal of unused functions:

  • Removed the import of add_driver_to_connection_str from mssql_python/helpers.py in connection.py, as it is no longer used.
  • Deleted the add_driver_to_connection_str function, which previously handled injecting a default ODBC driver into the connection string.
  • Deleted the add_driver_name_to_app_parameter function, which previously ensured the APP parameter was set in the connection string.

@github-actions github-actions bot added the pr-size: medium Moderate update size label Jan 9, 2026
@github-actions
Copy link

📊 Code Coverage Report

🔥 Diff Coverage

100%


🎯 Overall Coverage

76%


📈 Total Lines Covered: 5440 out of 7085
📁 Project: mssql-python


Diff Coverage

Diff: main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.


📋 Files Needing Attention

📉 Files with overall lowest coverage (click to expand)
mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.row.py: 66.2%
mssql_python.pybind.ddbc_bindings.cpp: 69.4%
mssql_python.pybind.ddbc_bindings.h: 71.7%
mssql_python.pybind.connection.connection.cpp: 73.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 84.1%
mssql_python.cursor.py: 84.8%

🔗 Quick Links

⚙️ Build Summary 📋 Coverage Details

View Azure DevOps Build

Browse Full Coverage Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-size: medium Moderate update size

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants