Skip to content

fix(diff-editor): support originalEditable in inline diff mode (#5302) - #5447

Open
Veeresh Yadav (veeresh4520) wants to merge 1 commit into
microsoft:mainfrom
veeresh4520:fix/issue-5302-inline-diff-original-editable
Open

fix(diff-editor): support originalEditable in inline diff mode (#5302)#5447
Veeresh Yadav (veeresh4520) wants to merge 1 commit into
microsoft:mainfrom
veeresh4520:fix/issue-5302-inline-diff-original-editable

Conversation

@veeresh4520

Copy link
Copy Markdown

Description

Fixes #5302.

The original model of an inline diff editor could not be edited even when originalEditable was set to true.

This change fixes the issue while preserving the existing readOnly behavior and adds a regression test to ensure the original model remains editable when the configuration allows it.

Changes

  • Fixed editing of the original model in inline diff editors.
  • Added a regression test covering originalEditable in inline diff mode.
  • Preserved existing behavior for side-by-side diff editors and read-only configurations.

Testing

  • Added a regression test for the reported configuration.
  • Ran the relevant diff editor tests.
  • Ran the applicable repository validation checks.

@veeresh4520

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agre e

@microsoft-github-policy-service

Copy link
Copy Markdown

Veeresh Yadav (@veeresh4520) the command you issued was incorrect. Please try again.

Examples are:

@microsoft-github-policy-service agree

and

@microsoft-github-policy-service agree company="your company"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Editing original model in inline diff viewer not possible even if it should be based on configuration options

1 participant