Microsoft.StorageSync | Adding arguments to trigger change detection command #1473
+71
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added required directory-path, optional change-detection-mode, and paths options to the cloud endpoint change detection command. Updated service and option definitions to support these parameters, and adjusted tests and documentation accordingly for improved flexibility and control.
Refactored StorageSyncService to set ChangeDetectionMode using the constructor instead of Enum.TryParse. Updated live test to use 'Recursive' mode and an empty paths array. Updated assets.json tag for live tests.
ankushbindlish2
requested review from
alzimmermsft,
chidozieononiwu,
fanyang-mono,
jongio,
joshfree,
sandeep-sen and
tmeschter
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the StorageSync cloud endpoint change detection command by adding optional parameters to provide more granular control over the change detection process. The changes replace the previous boolean recursive flag with a more flexible changeDetectionMode parameter and add support for specifying specific paths.
Key Changes:
- Replaces the
recursiveboolean parameter with achangeDetectionModestring parameter that accepts values like "Default" or "Recursive" - Changes
directoryPathfrom optional to required parameter - Adds a new
pathsparameter to allow specifying an array of specific paths for change detection - Updates tests, documentation, and command-line options to reflect the new parameter structure
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.StorageSync/src/Services/IStorageSyncService.cs | Updates method signature to replace recursive boolean and optional filePaths with required directoryPath and optional changeDetectionMode and paths parameters |
| tools/Azure.Mcp.Tools.StorageSync/src/Services/StorageSyncService.cs | Implements the new parameter handling logic, including conditional setting of change detection mode and path addition |
| tools/Azure.Mcp.Tools.StorageSync/src/Options/StorageSyncOptionDefinitions.cs | Replaces Recursive option with ChangeDetectionMode and Paths options with updated descriptions |
| tools/Azure.Mcp.Tools.StorageSync/src/Options/CloudEndpoint/CloudEndpointTriggerChangeDetectionOptions.cs | Adds properties for the new parameters: DirectoryPath, ChangeDetectionMode, and Paths |
| tools/Azure.Mcp.Tools.StorageSync/src/Commands/CloudEndpoint/CloudEndpointTriggerChangeDetectionCommand.cs | Updates command registration and option binding to use the new parameters, makes DirectoryPath required |
| tools/Azure.Mcp.Tools.StorageSync/tests/Azure.Mcp.Tools.StorageSync.LiveTests/StorageSyncCommandTests.cs | Updates test to include the new required parameters with sample values |
| tools/Azure.Mcp.Tools.StorageSync/tests/Azure.Mcp.Tools.StorageSync.LiveTests/assets.json | Updates the tag for recorded test assets |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Updates command documentation to show the new required and optional parameters |
| servers/Azure.Mcp.Server/docs/e2eTestPrompts.md | Updates the test prompt to include directory path parameter |
...Mcp.Tools.StorageSync/tests/Azure.Mcp.Tools.StorageSync.LiveTests/StorageSyncCommandTests.cs
Show resolved
Hide resolved
...Mcp.Tools.StorageSync/tests/Azure.Mcp.Tools.StorageSync.LiveTests/StorageSyncCommandTests.cs
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.StorageSync/src/Options/StorageSyncOptionDefinitions.cs
Outdated
Show resolved
Hide resolved
...cp.Tools.StorageSync/src/Options/CloudEndpoint/CloudEndpointTriggerChangeDetectionOptions.cs
Show resolved
Hide resolved
diberry
reviewed
Jan 10, 2026
...p.Tools.StorageSync/src/Commands/CloudEndpoint/CloudEndpointTriggerChangeDetectionCommand.cs
Outdated
Show resolved
Hide resolved
Renamed the 'triggerchangedetection' command and related references to 'changedetection' for consistency and clarity across the StorageSync tool, documentation, and tests. Updated option descriptions for improved clarity.
ankushbindlish2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes][Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline