Merged
Conversation
xiangyan99
requested review from
JasonYeMSFT,
Copilot,
fanyang-mono,
g2vinay,
hallipr,
jairmyree,
sandeep-sen and
tmeschter
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the --insecure-disable-elicitation server startup option to --dangerously-disable-elicitation to align with the naming convention used by other security-related options (e.g., --dangerously-disable-http-incoming-auth). This is a breaking change as the old option name is no longer supported.
Key Changes
- Renamed CLI option from
--insecure-disable-elicitationto--dangerously-disable-elicitation - Updated all references across code, documentation, and tests to use the new naming convention
- Updated terminology from "INSECURE" to "DANGEROUS" in user-facing messages
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| servers/Azure.Mcp.Server/vscode/CHANGELOG.md | Updated historical changelog entry with new option name (should preserve historical accuracy) |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Updated documentation to reflect new option name and terminology |
| servers/Azure.Mcp.Server/CHANGELOG.md | Added breaking change announcement for the rename |
| core/Microsoft.Mcp.Core/src/Commands/TelemetryConstants.cs | Updated telemetry tag name constant |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/ServiceStartCommandTests.cs | Updated unit tests to use new option name |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/ToolLoading/CommandFactoryToolLoaderTests.cs | Updated tool loader tests to use new option name |
| core/Azure.Mcp.Core/src/Areas/Server/Options/ServiceStartOptions.cs | Updated property name and JSON serialization name |
| core/Azure.Mcp.Core/src/Areas/Server/Options/ServiceOptionDefinitions.cs | Updated option definition constant and CLI option |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/ToolLoaderOptions.cs | Updated record parameter name |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/NamespaceToolLoader.cs | Updated option reference |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/CommandFactoryToolLoader.cs | Updated option reference |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/BaseToolLoader.cs | Updated parameter name, documentation, and warning message |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ServiceStartCommand.cs | Updated option registration and binding |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ServiceCollectionExtensions.cs | Updated service registration to use new property name |
alzimmermsft
approved these changes
Jan 14, 2026
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
* rename insecure-disable-elicitation to dangerously-disable-elicitation * fix typo * update changelog * update changelog * update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]rename insecure-disable-elicitation to dangerously-disable-elicitation
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline