Skip to content

Update new-command.md for more CancellationToken examples and instructions#1262

Closed
vukelich wants to merge 1 commit intomainfrom
users/vukelich/newcommand_morecancellation
Closed

Update new-command.md for more CancellationToken examples and instructions#1262
vukelich wants to merge 1 commit intomainfrom
users/vukelich/newcommand_morecancellation

Conversation

@vukelich
Copy link
Copy Markdown
Member

@vukelich vukelich commented Dec 1, 2025

There have been PRs since the series of "Great Cancellation" pull requests where some types aren't being generated with using CancellationToken. This PR is an attempt at incremental fixes to new-command.md for better async code generation.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the documentation in new-command.md to provide comprehensive guidance on proper CancellationToken usage in async methods, addressing issues where developers were omitting CancellationToken parameters in newly generated code.

Key Changes:

  • Added explicit CancellationToken cancellationToken parameter to all async method signatures in code examples throughout the documentation
  • Expanded guidance on when to use = default for CancellationToken parameters (only when other parameters also have defaults)
  • Added critical checklist items and "Do not"/"Always" guidelines emphasizing proper CancellationToken usage in service interfaces, implementations, command methods, and tests

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Dec 1, 2025
- When adding new tools, insert them in the correct alphabetical position to maintain sort order

## Add ne No newline at end of file
## Add ne
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a broken header for a new section which is supposed to begin with "## Add new ..."

@github-actions
Copy link
Copy Markdown

Hi @vukelich. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions
Copy link
Copy Markdown

Hi @vukelich. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions Bot closed this Feb 20, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants