Update new-command.md for more CancellationToken examples and instructions#1262
Update new-command.md for more CancellationToken examples and instructions#1262
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the documentation in new-command.md to provide comprehensive guidance on proper CancellationToken usage in async methods, addressing issues where developers were omitting CancellationToken parameters in newly generated code.
Key Changes:
- Added explicit
CancellationToken cancellationTokenparameter to all async method signatures in code examples throughout the documentation - Expanded guidance on when to use
= defaultforCancellationTokenparameters (only when other parameters also have defaults) - Added critical checklist items and "Do not"/"Always" guidelines emphasizing proper
CancellationTokenusage in service interfaces, implementations, command methods, and tests
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| - When adding new tools, insert them in the correct alphabetical position to maintain sort order | ||
|
|
||
| ## Add ne No newline at end of file | ||
| ## Add ne |
There was a problem hiding this comment.
This feels like a broken header for a new section which is supposed to begin with "## Add new ..."
|
Hi @vukelich. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @vukelich. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
There have been PRs since the series of "Great Cancellation" pull requests where some types aren't being generated with using
CancellationToken. This PR is an attempt at incremental fixes tonew-command.mdfor better async code generation.