fix: initialize res = None to prevent UnboundLocalError (#81)#1617
Open
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: initialize res = None to prevent UnboundLocalError (#81)#1617Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Conversation
The install commands without quotes fail in some shells (e.g., zsh). Using quoted version 'markitdown[all]' works universally. Closes microsoft#1574
When converter.accepts() returns False, the res variable is never assigned, causing UnboundLocalError when checking 'if res is not None'. This fix initializes res = None before the conversion attempt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #81 - UnboundLocalError: local variable 'res' referenced before assignment
When
converter.accepts()returns False, theresvariable is never assigned, causing an UnboundLocalError when checkingif res is not None.Fix
Initialize
res = Nonebefore the conversion attempt, ensuring the variable is always defined.Testing
This fix prevents the UnboundLocalError by ensuring
resis initialized toNonebefore the conditional block that assigns it.