fix: initialize res = None to prevent UnboundLocalError#1614
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: initialize res = None to prevent UnboundLocalError#1614Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When no converter accepts the file, res is referenced before assignment causing UnboundLocalError at line 616. Initialize res = None before the converter loop to fix this issue. Fixes microsoft#81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When no converter accepts the file,
resis referenced before assignment causingUnboundLocalErrorat line 616.Fix
Initialize
res = Nonebefore the converter loop to fix this issue.Test
The bug was triggered when:
converter.accepts()return False)if res is not None:butreswas never definedRelated
Fixes #81