-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix JSONL loader handling of blank/invalid lines #2434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+52
−1
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
96dae42
Fix JSONL loader for blank and invalid rows
natoverse 55f170f
Sync docs for schema and metadata fields
natoverse 3175286
Revert "Sync docs for schema and metadata fields"
natoverse 3bcba03
Merge branch 'main' into fix/2424-jsonl-loader-blank-lines
natoverse 8b2d8b0
Merge branch 'main' into fix/2424-jsonl-loader-blank-lines
natoverse c73f76b
Merge branch 'main' into fix/2424-jsonl-loader-blank-lines
natoverse 4b6ecb5
Merge branch 'main' into fix/2424-jsonl-loader-blank-lines
natoverse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "type": "patch", | ||
| "description": "Fix JSONL input loader to skip blank lines and ignore invalid JSON rows" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
tests/unit/indexing/input/data/jsonl-with-invalid-and-blank-lines/input.jsonl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { "title": "Hello", "text": "Hi how are you today?"} | ||
|
|
||
| not json | ||
| { "title": "Goodbye", "text": "I'm outta here"} | ||
|
|
||
| ["not", "an", "object"] | ||
| { "title": "Adios", "text": "See you later"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.