Remove stale crypto/ecdsa/badlinkname.go#2379
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ Ready to approve
The change cleanly removes an unused patch-added file and there are no remaining references to it in the patch set.
Note: this review does not count toward required approvals for merging.
Pull request overview
Removes the previously-added (now obsolete) src/crypto/ecdsa/badlinkname.go addition from the 0002-Add-crypto-backends patch, since PR #2371 eliminated the Windows ECDSA backend’s need for linkname access to crypto/ecdsa signature encode/decode helpers.
Changes:
- Drops
src/crypto/ecdsa/badlinkname.gofrom the patch’s file list and “create mode” entries. - Removes the patch hunk that created
src/crypto/ecdsa/badlinkname.go, and updates the patch summary stats accordingly.
File summaries
| File | Description |
|---|---|
| patches/0002-Add-crypto-backends.patch | Removes the stale crypto/ecdsa/badlinkname.go addition from the crypto backends patch set. |
Patches are happy!
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
gdams
approved these changes
Jun 18, 2026
Member
Author
|
@copilot fix conflicts |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto/ecdsa/badlinkname.gois no longer needed since #2371.