[release-branch.go1.26] Bump go-crypto-darwin to include HMAC SHA-3 f…#2375
Closed
michelle-clayton-work wants to merge 1 commit into
Closed
Conversation
…allback Update github.com/microsoft/go-crypto-darwin to 95c9561 to pick up microsoft/go-crypto-darwin#216, which makes NewHMAC return nil for hashes CryptoKit's HMAC cannot compute (e.g. SHA-3) instead of aborting the process with a Swift fatalError. This lets the standard library fall back to its pure Go HMAC implementation, completing the macOS side of the #2356 fix backported in #2360.
michelle-clayton-work
deleted the
dev/mclayton/backport-darwin-hmac-1.26-v2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…allback
Update github.com/microsoft/go-crypto-darwin to 95c9561 to pick up microsoft/go-crypto-darwin#216, which makes NewHMAC return nil for hashes CryptoKit's HMAC cannot compute (e.g. SHA-3) instead of aborting the process with a Swift fatalError. This lets the standard library fall back to its pure Go HMAC implementation, completing the macOS side of the #2356 fix backported in #2360.