Ship .asc signature alongside .sig#2348
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Microsoft Go’s release tooling to use .asc as the detached PGP signature file extension (matching upstream Go), while keeping .sig available for older toolchains/artifacts for backward compatibility.
Changes:
- Update
updatelinktableto generate signature links ending in.asc. - Update
signtool test mode to treat both.ascand.sigas signature files. - Update
signtool archive signing to generate.ascsignatures and optionally emit a legacy.sigcopy for older releases.
Show a summary per file
| File | Description |
|---|---|
| eng/_util/cmd/updatelinktable/updatelinktable.go | Switch signature URL suffix from .sig to .asc when generating download/link tables. |
| eng/_util/cmd/sign/sign.go | In test signing mode, treat both .sig and .asc outputs as signature placeholders. |
| eng/_util/cmd/sign/archive.go | Generate .asc signature artifacts and conditionally also produce legacy .sig copies. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
dagood
requested changes
Jun 4, 2026
gdams
changed the title
Produce an .asc PGP signature file alongside the existing .sig for every tar.gz archive. The .sig remains the default/primary extension; .asc is shipped in parallel for compatibility with upstream Go tooling (e.g. official Dockerfiles). Fixes #181
dagood
requested changes
Jun 12, 2026
dagood
left a comment
dagood
left a comment
Member
There was a problem hiding this comment.
Other than the comment, looks good.
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
Member
Author
|
@dagood updated PTAL |
dagood
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ship an
.ascPGP signature file alongside the existing.sigfor every archive. The.sigremains the default/primary extension;.ascis produced in parallel for compatibility with upstream Go tooling (e.g. official Dockerfiles).For #181
Changes
.sigvia signing, then copy both.sigand.ascto the destination directory.sigsignature files.sigremains the advertised suffix)Companion PR