Skip to content

fix(storybook): remove custom-babel-loader workaround #36385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulGMardling wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(storybook): remove custom-babel-loader workaround #36385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aaafd6
fix(storybook): remove custom-babel-loader workaround
PaulGMardling Jul 10, 2026
40f3976
fix(storybook): add change file
PaulGMardling Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...luentui-react-storybook-addon-export-to-sandbox-055ab233-3768-4a82-b636-fbd44c7644a0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "remove custom-babel-loader",
"packageName": "@fluentui/react-storybook-addon-export-to-sandbox",
"email": "paulmardling@microsoft.com",
"dependentChangeType": "patch"
}
13 changes: 0 additions & 13 deletions packages/react-components/react-storybook-addon-export-to-sandbox/src/custom-babel-loader.ts
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions packages/react-components/react-storybook-addon-export-to-sandbox/src/webpack.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe(`webpack`, () => {
enforce: 'post',
test: /\.stories\.(jsx?$|tsx?$)/,
use: {
loader: expect.stringContaining('custom-babel-loader'),
loader: expect.stringContaining('babel-loader'),
options: {
plugins: [
[
Expand Down Expand Up @@ -56,7 +56,7 @@ describe(`webpack`, () => {
test: /\.stories\.tsx?/,
include: /foo-stories/,
use: {
loader: expect.stringContaining('custom-babel-loader'),
loader: expect.stringContaining('babel-loader'),
options: {
plugins: [
[
Expand Down Expand Up @@ -93,7 +93,7 @@ describe(`webpack`, () => {
enforce: 'post',
test: /\.stories\.(jsx?$|tsx?$)/,
use: {
loader: expect.stringContaining('custom-babel-loader'),
loader: expect.stringContaining('babel-loader'),
options: {
plugins: [
[
Expand Down
6 changes: 1 addition & 5 deletions packages/react-components/react-storybook-addon-export-to-sandbox/src/webpack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,7 @@ function createBabelLoaderRule(config: Required<PresetConfig>): import('webpack'
*/
enforce: 'post',
use: {
/**
* Custom babel loader wraps the original babel-loader and fixes the incorrect `inputSourceMap` parameter
* that is passed to babel-loader.
**/
loader: require.resolve('./custom-babel-loader'),
loader: require.resolve('babel-loader'),
options: babelLoaderOptionsUpdater({
plugins: [plugin],
}),
Expand Down
4 changes: 4 additions & 0 deletions scripts/storybook/src/rules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ const swcRule = {
{
loader: 'swc-loader',
options: {
// Parse the source map to an object so subsequent loaders (e.g. babel-loader) receive
// an object rather than the raw JSON string that @swc/core outputs.
// Without this, babel-loader throws: "Error: .inputSourceMap must be a boolean, object, or undefined"
parseMap: true,
jsc: {
target: 'es2019',
parser: {
Expand Down
Loading