fix(react-tags): decouple useTagGroupBase_unstable from Tabster#36228
Merged
Conversation
This was referenced May 19, 2026
📊 Bundle size reportUnchanged fixtures
|
|
Pull request demo site: URL |
99f8a77 to
24a9f85
Compare
24a9f85 to
4af8734
Compare
4af8734 to
08cb5a5
Compare
layershifter
requested changes
May 20, 2026
Member
layershifter
left a comment
There was a problem hiding this comment.
Let's avoid UseTagGroupBaseOptions & options param to keep our hooks consistent
Hotell
reviewed
May 21, 2026
Contributor
Hotell
left a comment
There was a problem hiding this comment.
left some comments - needs changes/justification if there is no other way. ty
Member
|
@mainframev did you push the changes? I don't see any updates |
0ec6a47 to
c1ca43d
Compare
layershifter
approved these changes
May 26, 2026
e68087e to
0033314
Compare
Hotell
requested changes
May 26, 2026
Contributor
Hotell
left a comment
There was a problem hiding this comment.
this PR introduces BREAKING CHANGE in v9, these changes need to be reverted
0033314 to
b8f3d17
Compare
Hotell
approved these changes
May 26, 2026
daad91e to
7facc74
Compare
chore: update change file chore: update change files
7facc74 to
1e1391b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stack
This PR is part of a 3-PR stack. Review and merge bottom-up:
master) — merge firstSummary
useTagGroupBase_unstablefrom@fluentui/react-tabsterand@fluentui/react-shared-contexts. Arrow-key navigation and post-dismiss focus restoration are now pluggable via a new optionalUseTagGroupBaseOptionsargument (arrowNavigationProps,onAfterTagDismiss), mirroring theuseMenuTriggerBase_unstablepattern. The styleduseTagGroup_unstablekeeps full behaviour by supplying Tabster-backed implementations through that options bag.TagGroupContextProvider/useTagGroupContext_unstable,InteractionTagContextProvider/useInteractionTagContext_unstable, and theTagGroupContextValue/InteractionTagContextValuetypes. Also re-exports the previously-missingTagContextValuestype.