DRAFT: Introduce new Button appearance props ("tint" and "outlineColor") for CAP visual refresh#35844
Draft
GianoglioEnrico wants to merge 3 commits intomicrosoft:masterfrom
Draft
Conversation
|
Pull request demo site: URL |
📊 Bundle size report
Unchanged fixtures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is a draft PR — not intended for merge. The goal is to kickoff a discussion with the Fluent team on the right approach to introduce these new appearance variants needed for CAP visual refresh.
The styles used in this PR are not yet finalized and are still in progress.
Context
The CAP visual refresh requires two additional Button appearances beyond what Fluent currently offers:
tint— A button with a tinted background using brand colorsoutlineColor— A button with a colored outline using brand colorsAs discussed previously, CAP styles will be applied through
customStyleHooks_unstable.This PR introduces the two new appearances so that they can be styled through custom hooks. The appearances have been added to the style definitions (
useButtonStyles.styles.ts,....) but have no Fluent-specific styles associated with them, so both currently fall back to the secondary appearance style. CAP applies its own specific styles to both through custom hooks. We are looking for guidance on how these appearances should be handled on the Fluent side — specifically, whether Fluent should define its own base styles for tint and outlineColor.This PR also introduces a Fluent/CAP toggle in the Storybook docs for Button to preview style modes.