Skip to content

fix(react-motion): remove @internal from MotionRefForwarder exports#35828

Open
layershifter wants to merge 2 commits intomicrosoft:masterfrom
layershifter:fix/motion-ref-forwarder-reset
Open

fix(react-motion): remove @internal from MotionRefForwarder exports#35828
layershifter wants to merge 2 commits intomicrosoft:masterfrom
layershifter:fix/motion-ref-forwarder-reset

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Mar 3, 2026

Summary

  • Removes @internal JSDoc tag from MotionRefForwarder, MotionRefForwarderReset, and useMotionForwardedRef exports, making them part of the public API

Test plan

  • nx run react-motion:build succeeds and regenerates API report

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@layershifter layershifter force-pushed the fix/motion-ref-forwarder-reset branch from 9a3b1a2 to e1b8dce Compare March 3, 2026 09:32
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

📊 Bundle size report

✅ No changes found

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Pull request demo site: URL

@layershifter layershifter changed the title fix(react-motion): add MotionRefForwarderReset to prevent context leaking fix(react-motion): remove @internal from MotionRefForwarder exports Mar 3, 2026
@@ -0,0 +1,7 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Avatar Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png 6 Changed
vr-tests-react-components/Charts-DonutChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png 5570 Changed
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png 413 Changed
vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.chromium.png 616 Changed
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 145 Changed
vr-tests-react-components/Skeleton converged 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Skeleton converged.Opaque Skeleton with square - Dark Mode.default.chromium.png 2 Changed
vr-tests-react-components/TagPicker 3 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - RTL.chromium.png 635 Changed
vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png 658 Changed
vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png 677 Changed

There were 3 duplicate changes discarded. Check the build logs for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant