feat(react-checkbox): add useCheckboxBase_unstable hook#35826
Draft
dmytrokirpa wants to merge 3 commits intomasterfrom
Draft
feat(react-checkbox): add useCheckboxBase_unstable hook#35826dmytrokirpa wants to merge 3 commits intomasterfrom
dmytrokirpa wants to merge 3 commits intomasterfrom
Conversation
Implements base state hook for Checkbox component as part of the experimental base hooks initiative. The base hook extracts pure component logic while omitting design props (shape, size). - CheckboxBaseProps: omits shape, size - CheckboxBaseState: omits shape, size - useCheckboxBase_unstable: handles checked/indeterminate state (controlled/uncontrolled), onChange callback, ARIA attributes, focus management (useFocusWithin), input ref management, indeterminate layout effect, label slot with htmlFor, slot structure useCheckbox_unstable now calls useCheckboxBase_unstable and adds shape+size-specific checkmark icons. All new types and hooks exported from package index.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dmytrokirpa
changed the base branch from
experimental/component-base-hooks
to
master
dmytrokirpa
force-pushed
the
feat/react-checkbox-base-hooks
branch
from
350df88 to
e1eb221
Compare
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1107 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1236 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - RTL.default.chromium.png | 495 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 403 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 611 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 193 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 677 | Changed |
There were 3 duplicate changes discarded. Check the build logs for more information.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📊 Bundle size report
Unchanged fixtures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a base state hook for the Checkbox component as part of the experimental base hooks initiative.
What was implemented
useCheckboxBase_unstable— base hook forCheckboxcomponentCheckboxBaseProps(omitsshape,size)CheckboxBaseState(omitsshape,size)useControllableState) supporting tri-state (true,false,'mixed')onChangecallback with correct{ checked: val }datagetPartitionedNativeProps)useFocusWithinuseMergedRefs) for settingindeterminatepropindeterminatelayout effect (useIsomorphicLayoutEffect)type,checked,id)htmlFor,disabled,requiredpropsroot,input,indicator,label)Note on icon selection
The base hook uses medium-size square/checkmark icons by default.
useCheckbox_unstableoverrides the indicator children with the appropriate size+shape-specific icon based on thesizeandshapedesign props.Exports
All new types and hooks are exported from the package
index.ts. They are NOT exported from@fluentui/react-components.Test plan
npx tsc --noEmiton the package)🤖 Generated with Claude Code