-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(react-search): add useSearchBoxBase_unstable hook #35825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d7fd72e
feat(react-search): add useSearchBoxBase_unstable hook
dmytrokirpa 9e468a9
change file
dmytrokirpa 001ed62
chore: fix formatting and lint in react-search
dmytrokirpa 8c62d49
expose base hook and types
dmytrokirpa 18f457e
Merge branch 'master' into feat/react-search-base-hooks
dmytrokirpa e06099c
move default children for contentBefore and dismiss slots from base hook
dmytrokirpa 8304996
Merge branch 'master' into feat/react-search-base-hooks
dmytrokirpa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-search-a97ad746-5a21-4b09-b830-5532b7bd3ca2.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "feat: add base hooks for SearchBox", | ||
| "packageName": "@fluentui/react-search", | ||
| "email": "dmytrokirpa@microsoft.com", | ||
| "dependentChangeType": "patch" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
packages/react-components/react-search/library/src/SearchBox.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,16 @@ | ||
| export type { | ||
| SearchBoxChangeEvent, | ||
| SearchBoxProps, | ||
| SearchBoxBaseProps, | ||
| SearchBoxSlots, | ||
| SearchBoxState, | ||
| SearchBoxBaseState, | ||
| } from './components/SearchBox/index'; | ||
| export { | ||
| SearchBox, | ||
| renderSearchBox_unstable, | ||
| searchBoxClassNames, | ||
| useSearchBoxStyles_unstable, | ||
| useSearchBox_unstable, | ||
| useSearchBoxBase_unstable, | ||
| } from './components/SearchBox/index'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 9 additions & 2 deletions
11
packages/react-components/react-search/library/src/components/SearchBox/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,12 @@ | ||
| export { SearchBox } from './SearchBox'; | ||
| export type { SearchBoxChangeEvent, SearchBoxProps, SearchBoxSlots, SearchBoxState } from './SearchBox.types'; | ||
| export type { | ||
| SearchBoxChangeEvent, | ||
| SearchBoxProps, | ||
| SearchBoxBaseProps, | ||
| SearchBoxSlots, | ||
| SearchBoxState, | ||
| SearchBoxBaseState, | ||
| } from './SearchBox.types'; | ||
| export { renderSearchBox_unstable } from './renderSearchBox'; | ||
| export { useSearchBox_unstable } from './useSearchBox'; | ||
| export { useSearchBox_unstable, useSearchBoxBase_unstable } from './useSearchBox'; | ||
| export { searchBoxClassNames, useSearchBoxStyles_unstable } from './useSearchBoxStyles.styles'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.