feat(react-card): add useCardBase_unstable hook#35824
Draft
dmytrokirpa wants to merge 4 commits intomasterfrom
Draft
feat(react-card): add useCardBase_unstable hook#35824dmytrokirpa wants to merge 4 commits intomasterfrom
dmytrokirpa wants to merge 4 commits intomasterfrom
Conversation
|
Pull request demo site: URL |
…er, and CardPreview Implements base state hooks for all Card components as part of the experimental base hooks initiative. Each base hook extracts pure component logic while omitting design props. - CardBaseProps/CardBaseState: omits appearance, orientation, size useCardBase_unstable: handles focusMode, interactivity detection, selection (controlled/uncontrolled), focus management (useFocusWithin, useFocusableGroup), ARIA disabled, slot structure - CardFooterBaseProps/CardFooterBaseState: same as CardFooterProps/State (no design props) useCardFooterBase_unstable: handles slot structure (root, action) - CardHeaderBaseProps/CardHeaderBaseState: same as CardHeaderProps/State (no design props) useCardHeaderBase_unstable: handles slot structure, card selectable accessibility (referenceId management) - CardPreviewBaseProps/CardPreviewBaseState: same as CardPreviewProps/State (no design props) useCardPreviewBase_unstable: handles slot structure, card selectable label extraction from img elements All styled hooks now delegate to their base counterparts. All new types and hooks exported from package index.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dmytrokirpa
changed the base branch from
experimental/component-base-hooks
to
master
dmytrokirpa
force-pushed
the
feat/react-card-base-hooks
branch
from
f62e3fa to
be7f222
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1236 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png | 495 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 403 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1107 | Changed |
vr-tests-react-components/Charts-DonutChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 7530 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 413 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 723 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 505 | Changed |
vr-tests-react-components/Skeleton converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Skeleton converged.Translucent Skeleton with circle - High Contrast.default.chromium.png | 1 | Changed |
vr-tests-react-components/TagPicker 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
There were 4 duplicate changes discarded. Check the build logs for more information.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📊 Bundle size report
Unchanged fixtures
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds base state hooks for all Card components as part of the experimental base hooks initiative.
What was implemented
useCardBase_unstable— base hook forCardcomponentCardBaseProps(omitsappearance,orientation,size)CardBaseState(omitsappearance,orientation,size)useCardSelectable), focus management (useFocusWithin,useFocusableGroup), ARIA disabled, slot structureuseCardFooterBase_unstable— base hook forCardFootercomponentCardFooterBaseProps(same asCardFooterProps— no design props)CardFooterBaseState(same asCardFooterState— no design props)root,action)useCardHeaderBase_unstable— base hook forCardHeadercomponentCardHeaderBaseProps(same asCardHeaderProps— no design props)CardHeaderBaseState(same asCardHeaderState— no design props)useCardPreviewBase_unstable— base hook forCardPreviewcomponentCardPreviewBaseProps(same asCardPreviewProps— no design props)CardPreviewBaseState(same asCardPreviewState— no design props)Refactoring
useCard_unstablenow callsuseCardBase_unstableand addsappearance,orientation,sizeuseCardFooter_unstable,useCardHeader_unstable,useCardPreview_unstabledelegate to their base counterpartsExports
All new types and hooks are exported from the package
index.ts. They are NOT exported from@fluentui/react-components.Test plan
npx tsc --noEmiton the package)🤖 Generated with Claude Code