feat(react-rating): add useRatingBase_unstable hook#35823
Draft
dmytrokirpa wants to merge 3 commits intomasterfrom
Draft
feat(react-rating): add useRatingBase_unstable hook#35823dmytrokirpa wants to merge 3 commits intomasterfrom
dmytrokirpa wants to merge 3 commits intomasterfrom
Conversation
…unstable, and useRatingItemBase_unstable hooks Implements base state hooks for Rating, RatingDisplay, and RatingItem components that extract pure component logic without design props (color, size): - useRatingBase_unstable: manages radiogroup ARIA role, controlled/uncontrolled value, hover state tracking, and radio input structure; omits color and size - useRatingDisplayBase_unstable: manages img ARIA role, aria-labelledby from valueText/countText IDs, compact/full display modes; omits color and size - useRatingItemBase_unstable: manages fill width calculation, radio input slots for ARIA rating interaction, icon slots; omits color and size from context Adds corresponding Base props/state types using DistributiveOmit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dmytrokirpa
force-pushed
the
feat/react-rating-base-hooks
branch
from
ae10056 to
86b1df7
Compare
dmytrokirpa
changed the base branch from
experimental/component-base-hooks
to
master
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1236 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1107 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - RTL.default.chromium.png | 495 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 403 | Changed |
vr-tests-react-components/Charts-DonutChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 509 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 726 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 677 | Changed |
There were 3 duplicate changes discarded. Check the build logs for more information.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useRatingBase_unstablefor the Rating component: managesrole=radiogroup, controlled/uncontrolled value state, hover state, and onChange/onMouseOver/onMouseLeave event handlers; omitscolorandsizedesign propsuseRatingDisplayBase_unstablefor RatingDisplay: managesrole=img,aria-labelledbycomposition from valueText/countText IDs, compact vs. full display mode slot structure; omitscolorandsizedesign propsuseRatingItemBase_unstablefor RatingItem: manages icon fill width calculation, radio input ARIA labels,aria-labelfromitemLabelcallback, half/full value radio input slots; omitscolorandsize(from context) design propsRatingBaseProps/RatingBaseState,RatingDisplayBaseProps/RatingDisplayBaseState,RatingItemBaseProps/RatingItemBaseStatetypes usingDistributiveOmituseRating_unstable,useRatingDisplay_unstable, anduseRatingItem_unstableto delegate to base hooks, then add design propsindex.tsfiles, barrel files, and packageindex.tsDesign props excluded from base hooks
color,sizecolor,sizecolor(from context),size(from context)Structural/behavioral props retained in base hooks
max,name,step,value,defaultValue,onChange,itemLabel,iconFilled,iconOutline(Rating)compact,icon,max,count,value(RatingDisplay)value, icon fill width logic, radio inputs (RatingItem)Test plan
npx tsc -p packages/react-components/react-rating/library/tsconfig.json --noEmit)🤖 Generated with Claude Code