feat(react-persona): add usePersonaBase_unstable hook#35814
Draft
dmytrokirpa wants to merge 2 commits intomasterfrom
Draft
feat(react-persona): add usePersonaBase_unstable hook#35814dmytrokirpa wants to merge 2 commits intomasterfrom
dmytrokirpa wants to merge 2 commits intomasterfrom
Conversation
Enables the already-implemented usePersonaBase_unstable hook and PersonaBaseProps/ PersonaBaseState types by uncommenting and properly exporting them from the package index. The hook manages text slot structure (primaryText, secondaryText, etc.) without design props (size, textPosition, textAlignment, avatar, presence slots). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dmytrokirpa
force-pushed
the
feat/react-persona-base-hooks
branch
from
a221d3e to
a28c912
Compare
dmytrokirpa
changed the base branch from
experimental/component-base-hooks
to
master
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1107 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1236 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 403 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png | 495 | Changed |
vr-tests-react-components/Charts-DonutChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 7530 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 611 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 196 | Changed |
vr-tests-react-components/TagPicker 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.chromium.png | 635 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1319 | Changed |
There were 4 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usePersonaBase_unstablehook that was already implemented inusePersona.tsbut gated behind a comment inindex.tsPersonaBasePropsandPersonaBaseStatetypes from the packageindex.tsnumTextLinescount without design propsusePersona_unstabledelegates tousePersonaBase_unstableand addssize,textPosition,textAlignment,avatar, andpresenceslotsDesign props excluded from base hook
sizetextPositiontextAlignmentavatarslotpresenceslotPersonaBasePropsisComponentProps<Omit<PersonaSlots, 'avatar' | 'presence'>> & Pick<PersonaProps, 'name'>, keeping text slots and thenameprop.Test plan
npx tsc -p packages/react-components/react-persona/library/tsconfig.json --noEmit)usePersonaBase_unstableand base types are exported from the package index🤖 Generated with Claude Code