refactor(eslint-plugin-react-components): optimize identifier tracking in enforce-use-client rule#35772
Open
dmytrokirpa wants to merge 2 commits intomicrosoft:masterfrom
Conversation
…g in enforce-use-client rule
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
change/@fluentui-eslint-plugin-react-components-6a18a4aa-05fd-4ee8-aa41-50d42f4477e0.json
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Removes the
ImportDeclarationvisitor and moves all import-tracking logic intoIdentifier. Since ESLint visits each identifier node individually — including those inside import specifiers — the same sets can be built incrementally there, keeping all identifier-related logic in one place.No behavior changes; existing tests cover all affected paths.
Related Issue(s)