chore(react-icons): add bundle-size metrics,gates#877
Merged
Hotell merged 12 commits intomicrosoft:mainfrom Jan 14, 2026
Merged
chore(react-icons): add bundle-size metrics,gates#877Hotell merged 12 commits intomicrosoft:mainfrom
Hotell merged 12 commits intomicrosoft:mainfrom
Conversation
Hotell
changed the title
dmytrokirpa
previously approved these changes
Aug 6, 2025
Hotell
force-pushed
the
react-icons/bundle-size-check
branch
from
3154793 to
41b98d6
Compare
Hotell
force-pushed
the
react-icons/bundle-size-check
branch
from
41b98d6 to
88595e5
Compare
Hotell
commented
Jan 13, 2026
| * Creates a local storage adapter for Monosize. | ||
| * This adapter reads and writes bundle size reports to a local JSON file. | ||
| * It is used to store the bundle size reports locally for the package. | ||
| * TODO: needs to be reworked to leverage GHA artifacts because pushing from CI to protected branch is not allowed. |
Collaborator
Author
There was a problem hiding this comment.
this should no longer be the case, will remove once validated after merge
Hotell
changed the title
Hotell
force-pushed
the
react-icons/bundle-size-check
branch
from
f8f05e2 to
e75c684
Compare
Collaborator
Author
|
@dmytrokirpa please re-review. I revamped the storage mechanism with additional infra which should work as expected for all scenarios. ty ! |
dmytrokirpa
reviewed
Jan 14, 2026
Hotell
force-pushed
the
react-icons/bundle-size-check
branch
from
15b065d to
250a662
Compare
dmytrokirpa
approved these changes
Jan 14, 2026
This was referenced Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bundle size measurement and reporting for monorepo via
monosizetool.monosize measurefor existing fixturesmonosize compare-reportscomparing repo stored storage vs current PR measurementcreateLocalStoragemonosize adapter which operates on physical repo filesbuildtarget onreact-icons