Skip to content

Comments

Rename CSS variable --appbar-item-padding to --appbar-item-height-adjustment#4567

Merged
vnbaaij merged 3 commits intousers/vnbaaij/dev-v5/appbar-fixesfrom
copilot/sub-pr-4566
Feb 24, 2026
Merged

Rename CSS variable --appbar-item-padding to --appbar-item-height-adjustment#4567
vnbaaij merged 3 commits intousers/vnbaaij/dev-v5/appbar-fixesfrom
copilot/sub-pr-4566

Conversation

Copy link
Contributor

Copilot AI commented Feb 24, 2026

Pull Request

📖 Description

Renames the CSS variable --appbar-item-padding to --appbar-item-height-adjustment in the AppBar component. The old name was misleading — the variable is used as a height subtraction amount (calc(item-size - adjustment)), not as CSS padding.

Changed files:

  • FluentAppBar.razor.css — renamed variable declaration and its calc() usage
  • FluentAppBarItem.razor.cs — updated inline style reference
/* Before */
--appbar-item-padding: 10;
height: calc(var(--appbar-item-size) * 1px - var(--appbar-item-padding) * 1px);

/* After */
--appbar-item-height-adjustment: 10;
height: calc(var(--appbar-item-size) * 1px - var(--appbar-item-height-adjustment) * 1px);

🎫 Issues

Addresses review feedback on #4566.

👩‍💻 Reviewer Notes

Pure rename — no behavioral change. All three occurrences of --appbar-item-padding have been updated.

📑 Test Plan

All 28 existing AppBar unit tests pass unchanged.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

MCP Server

  • I have added or updated MCP Server tools/prompts/resources
  • I have added Unit Tests for my MCP Server changes

⏭ Next Steps

Merge into #4566 once approved.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 24, 2026 11:12
Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Copilot AI changed the title [WIP] Update CSS variable for AppBar item height adjustment Rename CSS variable --appbar-item-padding to --appbar-item-height-adjustment Feb 24, 2026
Copilot AI requested a review from vnbaaij February 24, 2026 11:15
@vnbaaij vnbaaij marked this pull request as ready for review February 24, 2026 12:15
@vnbaaij vnbaaij requested a review from dvoituron as a code owner February 24, 2026 12:15
Copilot AI review requested due to automatic review settings February 24, 2026 12:15
@vnbaaij vnbaaij merged commit e0aa6f5 into users/vnbaaij/dev-v5/appbar-fixes Feb 24, 2026
1 check passed
@vnbaaij vnbaaij deleted the copilot/sub-pr-4566 branch February 24, 2026 12:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames an AppBar CSS custom property from --appbar-item-padding to --appbar-item-height-adjustment to better reflect its actual use (a subtraction/adjustment in height calculations) and updates the corresponding inline style usage in the AppBar item component.

Changes:

  • Renamed the CSS variable in FluentAppBar.razor.css and updated its calc() usage.
  • Updated FluentAppBarItem inline min-height style to reference the new variable name.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Core/Components/AppBar/FluentAppBar.razor.css Renames the custom property and updates the height: calc(...) expression to use the new name.
src/Core/Components/AppBar/FluentAppBarItem.razor.cs Updates the vertical min-height inline style calculation to reference the renamed CSS variable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants