Rename CSS variable --appbar-item-padding to --appbar-item-height-adjustment#4567
Merged
vnbaaij merged 3 commits intousers/vnbaaij/dev-v5/appbar-fixesfrom Feb 24, 2026
Merged
Conversation
Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update CSS variable for AppBar item height adjustment
Rename CSS variable --appbar-item-padding to --appbar-item-height-adjustment
Feb 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames an AppBar CSS custom property from --appbar-item-padding to --appbar-item-height-adjustment to better reflect its actual use (a subtraction/adjustment in height calculations) and updates the corresponding inline style usage in the AppBar item component.
Changes:
- Renamed the CSS variable in
FluentAppBar.razor.cssand updated itscalc()usage. - Updated
FluentAppBarIteminlinemin-heightstyle to reference the new variable name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Core/Components/AppBar/FluentAppBar.razor.css | Renames the custom property and updates the height: calc(...) expression to use the new name. |
| src/Core/Components/AppBar/FluentAppBarItem.razor.cs | Updates the vertical min-height inline style calculation to reference the renamed CSS variable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Renames the CSS variable
--appbar-item-paddingto--appbar-item-height-adjustmentin the AppBar component. The old name was misleading — the variable is used as a height subtraction amount (calc(item-size - adjustment)), not as CSS padding.Changed files:
FluentAppBar.razor.css— renamed variable declaration and itscalc()usageFluentAppBarItem.razor.cs— updated inline style reference🎫 Issues
Addresses review feedback on #4566.
👩💻 Reviewer Notes
Pure rename — no behavioral change. All three occurrences of
--appbar-item-paddinghave been updated.📑 Test Plan
All 28 existing AppBar unit tests pass unchanged.
✅ Checklist
General
Component-specific
MCP Server
⏭ Next Steps
Merge into #4566 once approved.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.