[DO NOT REVIEW] Adding RetryFact and RetryTheory to all tests

[jestradaMS]

Description

Describe the changes in this PR.

Related issues

Addresses [issue #].

Testing

Describe how this change was tested.

FHIR Team Checklist

• Update the title of the PR to be succinct and less than 65 characters
• Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
• Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
• Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
• Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
• When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
• CI is green before merge
• Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

To fix this issue, remove the constant condition check if (lastException != null) at line 158. Since lastException is always non-null at this point, its inner block (assigning to aggregator and so forth) should be unconditionally executed. Replace the conditional block with a direct execution of its contents, simplifying the code and matching the intended flow without changing program semantics.

Only lines 158–161 are directly affected:

if (lastException != null)
{
    aggregator.Add(lastException);
}

should become simply:

aggregator.Add(lastException);

No imports, definitions, or additional changes are required.

---

To fix the useless assignment issue flagged on line 99 (lastException = ex;), simply remove this statement, since the assigned value to lastException is never read in this execution path (the method will always exit at the subsequent throw;). The change should be made in src/Microsoft.Health.Extensions.Xunit/RetryDelayEnumeratedTheoryTestCase.cs, within the catch block that handles generic Exception ex, replacing:

lastException = ex;
throw;

with just:

throw;

No other code, imports, method definitions, or usage of lastException should be changed, as this assignment is not read and its removal does not affect side effects or overall method functionality.

---

To fix the issue, refactor the conditional assignment to use the conditional (ternary) operator instead of an if/else statement. Specifically, in the snippet:

if (isAssertionFailure)
{
    lastException = new XunitException(fullMessage);
}
else
{
    lastException = new InvalidOperationException(fullMessage);
}

Replace this block with a single assignment using the ternary operator:

lastException = isAssertionFailure
    ? new XunitException(fullMessage)
    : new InvalidOperationException(fullMessage);

This change should be made inside src/Microsoft.Health.Extensions.Xunit/RetryDelayEnumeratedTheoryTestCase.cs, replacing lines 139–146 with the new condensed assignment. No new imports or methods are needed, as the types involved are already referenced.

[jestradaMS]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).