Skip to content

Support f-children element filters#7658

Open
pradeep-ramola wants to merge 1 commit into
microsoft:mainfrom
pradeep-ramola:pradeep-ramola/f-children-filter-elements
Open

Support f-children element filters#7658
pradeep-ramola wants to merge 1 commit into
microsoft:mainfrom
pradeep-ramola:pradeep-ramola/f-children-filter-elements

Conversation

@pradeep-ramola

Copy link
Copy Markdown
Contributor

Pull Request

📖 Description

Updates the declarative template parser so f-children supports the same filter elements(...) syntax that f-slotted already supports.

Previously, f-children="{childItems filter elements()}" treated the whole string as the property name. Now it resolves to children({ property: "childItems", filter: elements() }).

🎫 Issues

Fixes #7631

👩‍💻 Reviewer Notes

The parser now shares node directive option parsing between children() and slotted(). Existing f-slotted behavior is preserved.

📑 Test Plan

Tested locally with:

  • npx playwright test src/declarative/template-bridge.pw.spec.ts --project=chromium
  • npm run build:tsc -w @microsoft/fast-element
  • npm run lint -w @microsoft/fast-element
  • npx beachball check --branch origin/main

Note: Firefox/WebKit Playwright browsers are not installed locally, so the all-browser run could not complete. Chromium passed.

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Agents

  • I have linked to an existing issue in this project that this change addresses
  • I have read the skills
  • I have read the DESIGN.md file(s) in packages relevent to my changes
  • I have updated the DESIGN.md file(s) in packages relevent to my changes

⏭ Next Steps

No follow-up work is planned for this PR.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: support filters for f-children in declarative templates

1 participant