Support f-children element filters#7658
Open
pradeep-ramola wants to merge 1 commit into
Open
Conversation
pradeep-ramola
requested review from
chrisdholt,
janechu and
radium-v
as code owners
July 20, 2026 09:29
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Updates the declarative template parser so
f-childrensupports the samefilter elements(...)syntax thatf-slottedalready supports.Previously,
f-children="{childItems filter elements()}"treated the whole string as the property name. Now it resolves tochildren({ property: "childItems", filter: elements() }).🎫 Issues
Fixes #7631
👩💻 Reviewer Notes
The parser now shares node directive option parsing between
children()andslotted(). Existingf-slottedbehavior is preserved.📑 Test Plan
Tested locally with:
npx playwright test src/declarative/template-bridge.pw.spec.ts --project=chromiumnpm run build:tsc -w @microsoft/fast-elementnpm run lint -w @microsoft/fast-elementnpx beachball check --branch origin/mainNote: Firefox/WebKit Playwright browsers are not installed locally, so the all-browser run could not complete. Chromium passed.
✅ Checklist
General
$ npm run changeAgents
⏭ Next Steps
No follow-up work is planned for this PR.