fix: replace arrays during observerMap deepMerge#7559
Open
janechu wants to merge 7 commits into
Open
Conversation
1aa8dbf to
038190c
Compare
janechu
commented
Jun 4, 2026
038190c to
e30b8b9
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
e30b8b9 to
88a4d7e
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fix observer-map-managed array updates so
deepMergereplaces arrays instead ofmutating existing observed arrays in place.
array notification work.
notification path.
Test Plan
npm run build -w @microsoft/fast-htmlnpm run build:tsc -w @microsoft/fast-htmlnpm run lint -w @microsoft/fast-htmlnpm run test:chromium -w @microsoft/fast-html -- test/fixtures/deep-merge/deep-merge.spec.tsnpm run checkchangeChecklist
General
$ npm run change