Skip to content

fixed terraform and sets as per new standards#229

Merged
renatolfc merged 1 commit intomicrosoft:mainfrom
krishnaglodha:hotfix/local-setup
Jul 28, 2025
Merged

fixed terraform and sets as per new standards#229
renatolfc merged 1 commit intomicrosoft:mainfrom
krishnaglodha:hotfix/local-setup

Conversation

@krishnaglodha
Copy link
Copy Markdown
Contributor

Currently local setup does not work because some code is not as per latest standard

@krishnaglodha
Copy link
Copy Markdown
Contributor Author

@krishnaglodha please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Copy Markdown
Contributor

@renatolfc renatolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing this, @krishnaglodha. Looks good to me.

We'll probably need an update to the AKS terraform files as well, but there's no need to block this PR.

@krishnaglodha
Copy link
Copy Markdown
Contributor Author

should I fix in AKS as well ?

@renatolfc
Copy link
Copy Markdown
Contributor

No need to. There are more fixes needed for AKS and I'd rather not block on that.

If you don't mind, I'll be merging this and we can fix AKS later.

@renatolfc renatolfc merged commit 99e1fc1 into microsoft:main Jul 28, 2025
9 checks passed
renatolfc added a commit that referenced this pull request Jul 28, 2025
@krishnaglodha krishnaglodha deleted the hotfix/local-setup branch July 29, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants