fix: clear orchestrationQueueSet in InMemoryOrchestrationBackend.reset()#133
Open
YunchuWang wants to merge 1 commit intomainfrom
Open
Conversation
The reset() method clears the orchestrationQueue array but does not clear the orchestrationQueueSet. When an orchestration is created and reset() is called before the orchestration is dequeued, the Set retains the stale instance ID. Any subsequent createInstance() call with the same ID after reset is silently skipped by enqueueOrchestration() because the Set still reports the ID as present. This causes the orchestration to never be processed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Fixes a state-reset bug in the in-memory testing backend where reset() cleared the orchestration queue array but left its de-duplication Set populated, preventing re-enqueue of the same instance ID after a reset.
Changes:
- Clear
orchestrationQueueSetinInMemoryOrchestrationBackend.reset(). - Add a regression test that reproduces “instance ID reuse after reset” and verifies the orchestration is processed successfully.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/durabletask-js/src/testing/in-memory-backend.ts | Clears the queue de-duplication set during reset() to fully reset queueing state. |
| packages/durabletask-js/test/in-memory-backend.spec.ts | Adds a regression test ensuring instance IDs can be reused after backend.reset() when an item was still queued. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reset() method clears the orchestrationQueue array but does not clear the orchestrationQueueSet. When an orchestration is created and reset() is called before the orchestration is dequeued, the Set retains the stale instance ID. Any subsequent createInstance() call with the same ID after reset is silently skipped by enqueueOrchestration() because the Set still reports the ID as present.
This causes the orchestration to never be processed.
Summary
What changed?
Why is this change needed?
Issues / work items
Project checklist
CHANGELOG.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
AI verification (required if AI was used):
Testing
Automated tests
Manual validation (only if runtime/behavior changed)
1.
2.
3.
Notes for reviewers