Fix/deployment catalog widget#15
Merged
Merged
Conversation
The evaluation and deployment job notebooks derived the catalog (and, in deployment, the personal schema) by parsing model_name, which is fragile and diverges from every other notebook. Use the standard catalog_name and user_schema widgets (with the same interactive fallback the other job notebooks use) and pass both from var.catalog_name / var.user_schema in the deployment job tasks. Regenerate src.
… vars The ML-outputs schema was called user_schema / user_workspace, but that name is only accurate in development mode. On the clean dev/staging/prod targets there is no per-user prefixing and it resolves to the shared fraud schema, so the name was misleading. Rename the variable to ml_schema and the schema resource key to ml_workspace, matching the layer-role naming of gold_schema and describing what the schema holds (features, model, predictions, monitoring) rather than who owns it. Also promote bronze_schema / silver_schema / landing_schema to bundle variables (defaults fraud_bronze / fraud_silver / fraud_landing) so every medallion schema is passed through consistently, the same way gold_schema already is, instead of being hardcoded literals in the ingestion workflow. Regenerate src. Note: renaming the ml_workspace resource key changes its bundle state address, so the first bundle deploy after this recreates that schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move some hardcoded catalogs / schemas to the widgets