Skip to content

[Build] Add flag to build-win.ps1 that allows to build Release.static target #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomsonTan merged 4 commits into from
Feb 6, 2026
Merged

[Build] Add flag to build-win.ps1 that allows to build Release.static target #1408

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c41a33
[Build] Add flag to build-win.ps1 that allows to build Release.static…
lucianopa-msft Jan 28, 2026
755b820
Merge branch 'main' into lucianopa/build-win-fix
ThomsonTan Jan 28, 2026
f32f26a
Update build-win.ps1
lucianopa-msft Jan 28, 2026
5d97f94
Merge branch 'main' into lucianopa/build-win-fix
lucianopa-msft Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions build-win.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ param (
[string]$enableMini = "true",
[string]$enableTests = "true",
[string]$customProps = "",
[string]$vsDevCmdBat = "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\Tools\VsDevCmd.bat"
[string]$vsDevCmdBat = "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\Tools\VsDevCmd.bat",
[string]$libMTSqlite= "true"
Comment thread
lucianopa-msft marked this conversation as resolved.
Outdated
)

$solution = "Solutions\MSTelemetrySDK.sln"
Expand Down Expand Up @@ -59,7 +60,11 @@ foreach ($arch in $archs) {
foreach ($config in $configs) {
$actualConfig = $config
if ($binType -eq "lib") {
$actualConfig += ".vc14x.MT-sqlite"
if ($libMTSqlite -eq "true") {
$actualConfig += ".vc14x.MT-sqlite"
} else {
$actualConfig += ".static"
Copy link
Copy Markdown
Contributor

@ThomsonTan ThomsonTan Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because static libs are only supported for x86/x64, should a check be added here to do the guard?

Copy link
Copy Markdown
Member Author

@lucianopa-msft lucianopa-msft Feb 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a check bellow on line 83

if ($binType -eq "lib" -and ($actualArch -eq "ARM")) {

that will skip building static lib anyways for arm.
It could be done earlier, but checking here would be redundant

}
}

echo "Building $actualArch|$actualConfig|$binType..."
Expand Down
Loading