build(golang-x-telemetry,golang-github-cncf-xds): temporarily break dependency cycles - #18457
Merged
Merged
Conversation
…ependency cycles Enable bootstrap builds for golang-x-telemetry and cncf-xds to seed the two circular dependency chains in azl4. This is a temporary change and must be reverted after the normal packages are rebuilt. Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Temporarily enables reduced bootstrap builds to break two Stage 2 Go dependency cycles.
Changes:
- Enables bootstrap mode for telemetry and xDS.
- Adds xDS overlays to skip dynamic dependencies and tests.
- Refreshes generated specs, macros, and locks.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/golang-x-telemetry/golang-x-telemetry.comp.toml |
Enables telemetry bootstrap mode. |
base/comps/golang-github-cncf-xds/golang-github-cncf-xds.comp.toml |
Adds xDS bootstrap configuration and overlays. |
base/comps/components.toml |
Moves both components to dedicated definitions. |
specs/g/golang-x-telemetry/golang-x-telemetry.spec |
Renders telemetry bootstrap configuration. |
specs/g/golang-x-telemetry/golang-x-telemetry.azl.macros |
Enables telemetry’s bootstrap bcond. |
specs/g/golang-github-cncf-xds/golang-github-cncf-xds.spec |
Renders xDS bootstrap behavior. |
specs/g/golang-github-cncf-xds/golang-github-cncf-xds.azl.macros |
Enables xDS’s bootstrap bcond. |
locks/golang-x-telemetry.lock |
Refreshes telemetry’s input fingerprint. |
locks/golang-github-cncf-xds.lock |
Refreshes xDS’s input fingerprint. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Mitch Zhu (miz060)
marked this pull request as ready for review
August 14, 2026 22:29
Member
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Member
|
Merging as a temporary workaround; we will revert this change after we can get through the bootstrap steps. |
reuben olinsky (reubeno)
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Stage 2 rebuild is blocked by two circular dependency chains:
golang-x-telemetryrequiresgolang-x-exp-devel, which reachesgolang-x-tools-devel, which requires telemetry.golang-github-cncf-xdsrequiresgolang-google-grpc-devel, which requires xDS.This temporary change enables the existing
bootstrapmode forgolang-x-telemetryand adds equivalent bootstrap handling togolang-github-cncf-xds. In bootstrap mode, both packages skip dynamic Go BuildRequires and tests while still producing their source-only-develRPMs and Go capability provides. These reduced packages can seedazl4, allowing the normal packages on both sides of each cycle to build after the repository is regenerated.This change should be reverted after the reduced packages are published and the normal telemetry and xDS packages have been rebuilt.
Validation: