Skip to content

[Medium] patch golang-1.26.5 for CVE-2026-46600. - #18422

Closed
AkarshHCL wants to merge 2 commits into
microsoft:3.0-devfrom
Kanishk-Bansal:topic_Akarsh_golang_CVE-2026-46600
Closed

[Medium] patch golang-1.26.5 for CVE-2026-46600.#18422
AkarshHCL wants to merge 2 commits into
microsoft:3.0-devfrom
Kanishk-Bansal:topic_Akarsh_golang_CVE-2026-46600

Conversation

@AkarshHCL

@AkarshHCL AkarshHCL commented Aug 14, 2026

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Vulnerability Summary

This PR fixes CVE-2026-46600,Parsing an invalid SVCB or HTTPS RR can panic when the size of a parameter value overflows the message buffer. .

Backport adaptations for golang-1.26.5
  1. Removed the tests from patch as their is no check section in our spec. Even the file to which those tests are being added is not present in our sources.
  2. Rest fix applies as it is as in upstream patch.
  3. But tested the test present in upstream patch against the fixed rpms and unfixed rpms output of both pasted in the test methodology section.
Change Log
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

Screenshot of successful local build-
image

patch is getting applied cleanly-
image

Tried the test present in the upstream against the fixed and unfixed rpms patch ran test with -v option it is required to Go's own verbose flag — produces the === RUN / --- PASS lines. Cosmetic.
Before fix output-
image

After fix-
image

@AkarshHCL
AkarshHCL requested a review from a team as a code owner August 14, 2026 07:56
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Aug 14, 2026
@AkarshHCL
AkarshHCL marked this pull request as draft August 14, 2026 07:57
@v-aaditya

Copy link
Copy Markdown

Peer-review analysis -

  1. The golang version 1.26.5 vendors golang.org/x/net version 0.47 which is in affected range of < 0.56.0.
  2. Affected file go/src/vendor/golang.org/x/net/dns/dnsmessage/svcb.go, function unpackSVCBResource() and affected code are present.
  3. The patch completely matches with upstream patch except that the changes in file go/src/vendor/golang.org/x/net/dns/dnsmessage/message_test.go are not included as it does not exist in current source.
  4. The patch has upstream reference.
  5. The patch applies cleanly. (Checked .rpm.log)
  6. The latest Buddy Build has passed.

Verdict - LGTM.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@Kanishk-Bansal

Copy link
Copy Markdown

will be covered in #18437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants