Skip to content

fix: address build failures due to missing dependencies #16458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherco merged 7 commits into from
Apr 4, 2026
Merged

fix: address build failures due to missing dependencies #16458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b9c9db3
fix(rust-gix-archive): allow rust-zip 8
trungams Apr 3, 2026
09d2273
fix(rust-schemars): pin to version 1.2.1
trungams Apr 3, 2026
12bbb70
fix(rust-zerocopy): pin to version 0.8.42
trungams Apr 3, 2026
c61a05e
fix(trustee-guest-components): pin to version 0.13.0
trungams Apr 3, 2026
f2406dc
fix(uv): pin to version 0.10.12
trungams Apr 3, 2026
0c5aff9
fix(golang-github-envoyproxy-control-plane): disable %generate_buildr…
trungams Apr 3, 2026
da38b8e
fix(golang-x-exp): enable bootstrap build
trungams Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions base/comps/components-full.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,6 @@
[components.golang-github-eclipse-paho-mqtt]
[components.golang-github-elazarl-goproxy]
[components.golang-github-emicklei-restful]
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes golang-github-envoyproxy-control-plane, golang-x-exp, rust-gix-archive, rust-schemars, rust-zerocopy, trustee-guest-components, and uv from components-full.toml. If components-full.toml is used as the authoritative input for the “full” build set, these components will no longer be included/built, which conflicts with the PR goal of fixing build failures via pins/overlays. Consider keeping these [components.*] entries in components-full.toml and relying on the new per-component .comp.toml files to apply the pin/overlay behavior instead.

Suggested change
[components.golang-github-emicklei-restful]
[components.golang-github-emicklei-restful]
[components.golang-github-envoyproxy-control-plane]

Copilot uses AI. Check for mistakes.
[components.golang-github-envoyproxy-control-plane]
[components.golang-github-envoyproxy-protoc-gen-validate]
[components.golang-github-errors]
[components.golang-github-etcd-io-gofail]
Expand Down Expand Up @@ -1326,7 +1325,6 @@
[components.golang-uber-zap]
[components.golang-x-arch]
[components.golang-x-crypto]
[components.golang-x-exp]
[components.golang-x-mod]
[components.golang-x-net]
Comment on lines 1325 to 1329
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes golang-github-envoyproxy-control-plane, golang-x-exp, rust-gix-archive, rust-schemars, rust-zerocopy, trustee-guest-components, and uv from components-full.toml. If components-full.toml is used as the authoritative input for the “full” build set, these components will no longer be included/built, which conflicts with the PR goal of fixing build failures via pins/overlays. Consider keeping these [components.*] entries in components-full.toml and relying on the new per-component .comp.toml files to apply the pin/overlay behavior instead.

Copilot uses AI. Check for mistakes.
[components.golang-x-oauth2]
Expand Down Expand Up @@ -5615,7 +5613,6 @@
[components.rust-git2-curl]
[components.rust-git2]
[components.rust-gix-actor]
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes golang-github-envoyproxy-control-plane, golang-x-exp, rust-gix-archive, rust-schemars, rust-zerocopy, trustee-guest-components, and uv from components-full.toml. If components-full.toml is used as the authoritative input for the “full” build set, these components will no longer be included/built, which conflicts with the PR goal of fixing build failures via pins/overlays. Consider keeping these [components.*] entries in components-full.toml and relying on the new per-component .comp.toml files to apply the pin/overlay behavior instead.

Suggested change
[components.rust-gix-actor]
[components.rust-gix-actor]
[components.rust-gix-archive]

Copilot uses AI. Check for mistakes.
[components.rust-gix-archive]
[components.rust-gix-attributes]
[components.rust-gix-bitmap]
[components.rust-gix-blame]
Expand Down Expand Up @@ -6325,7 +6322,6 @@
[components.rust-scan_fmt]
[components.rust-scc]
[components.rust-scheduled-thread-pool]
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes golang-github-envoyproxy-control-plane, golang-x-exp, rust-gix-archive, rust-schemars, rust-zerocopy, trustee-guest-components, and uv from components-full.toml. If components-full.toml is used as the authoritative input for the “full” build set, these components will no longer be included/built, which conflicts with the PR goal of fixing build failures via pins/overlays. Consider keeping these [components.*] entries in components-full.toml and relying on the new per-component .comp.toml files to apply the pin/overlay behavior instead.

Suggested change
[components.rust-scheduled-thread-pool]
[components.rust-scheduled-thread-pool]
[components.rust-schemars]

Copilot uses AI. Check for mistakes.
[components.rust-schemars]
[components.rust-schemars_derive]
[components.rust-scoped-tls]
[components.rust-scoped_threadpool]
Expand Down Expand Up @@ -6776,7 +6772,6 @@
[components.rust-zbus_macros]
[components.rust-zbus_names]
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes golang-github-envoyproxy-control-plane, golang-x-exp, rust-gix-archive, rust-schemars, rust-zerocopy, trustee-guest-components, and uv from components-full.toml. If components-full.toml is used as the authoritative input for the “full” build set, these components will no longer be included/built, which conflicts with the PR goal of fixing build failures via pins/overlays. Consider keeping these [components.*] entries in components-full.toml and relying on the new per-component .comp.toml files to apply the pin/overlay behavior instead.

Suggested change
[components.rust-zbus_names]
[components.rust-zbus_names]
[components.rust-zerocopy]

Copilot uses AI. Check for mistakes.
[components.rust-zerocopy-derive]
[components.rust-zerocopy]
[components.rust-zerofrom-derive]
[components.rust-zerofrom]
[components.rust-zeroize]
Expand Down Expand Up @@ -6997,7 +6992,6 @@
[components.triehash]
[components.trilead-ssh2]
[components.trivy]
[components.trustee-guest-components]
[components.tslib]
[components.tss2]
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes golang-github-envoyproxy-control-plane, golang-x-exp, rust-gix-archive, rust-schemars, rust-zerocopy, trustee-guest-components, and uv from components-full.toml. If components-full.toml is used as the authoritative input for the “full” build set, these components will no longer be included/built, which conflicts with the PR goal of fixing build failures via pins/overlays. Consider keeping these [components.*] entries in components-full.toml and relying on the new per-component .comp.toml files to apply the pin/overlay behavior instead.

Suggested change
[components.tss2]
[components.tss2]
[components.golang-github-envoyproxy-control-plane]
[components.golang-x-exp]
[components.rust-gix-archive]
[components.rust-schemars]
[components.rust-zerocopy]
[components.trustee-guest-components]
[components.uv]

Copilot uses AI. Check for mistakes.
[components.ttembed]
Expand Down Expand Up @@ -7038,7 +7032,6 @@
[components.utf8proc]
[components.uthash]
[components.uuid]
[components.uv]
[components.v4l-utils]
[components.vala]
Comment on lines 7032 to 7036
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes golang-github-envoyproxy-control-plane, golang-x-exp, rust-gix-archive, rust-schemars, rust-zerocopy, trustee-guest-components, and uv from components-full.toml. If components-full.toml is used as the authoritative input for the “full” build set, these components will no longer be included/built, which conflicts with the PR goal of fixing build failures via pins/overlays. Consider keeping these [components.*] entries in components-full.toml and relying on the new per-component .comp.toml files to apply the pin/overlay behavior instead.

Copilot uses AI. Check for mistakes.
[components.valgrind]
Expand Down
14 changes: 14 additions & 0 deletions ...s/golang-github-envoyproxy-control-plane/golang-github-envoyproxy-control-plane.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# golang-github-sagikazarmark-crypt has been a dead package since Fedora 43, which breaks
# the transitive dependency chain: %go_generate_buildrequires generates imports that
# transitively pull in golang-sigs-k8s-aws-iam-authenticator-devel →
# golang-github-spf13-viper-devel → golang(github.com/sagikazarmark/crypt/config).
# Remove this overlay once golang-github-sagikazarmark-crypt is available or viper
# no longer requires it.
[components.golang-github-envoyproxy-control-plane]

[[components.golang-github-envoyproxy-control-plane.overlays]]
description = "Disable dynamic BuildRequires generation — transitive dep on dead golang-github-sagikazarmark-crypt"
type = "spec-search-replace"
section = "%generate_buildrequires"
regex = '%go_generate_buildrequires'
replacement = '# Disabled: transitive dep on dead golang-github-sagikazarmark-crypt (see comp.toml)'
9 changes: 9 additions & 0 deletions base/comps/golang-x-exp/golang-x-exp.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# The spec uses %go_generate_buildrequires which auto-detects Go imports. Without the
# bootstrap bcond, this generates a dependency on golang(golang.org/x/tools/go/packages/packagestest)
# which golang-x-tools does not provide. Enabling bootstrap skips dynamic dep generation,
# %build (no CLI binaries), and %check (tests). Only the -devel Go library subpackage
# is produced.
[components.golang-x-exp]

[components.golang-x-exp.build]
with = ["bootstrap"]
6 changes: 6 additions & 0 deletions base/comps/rust-gix-archive/rust-gix-archive.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Pin to commit that supports rust-zip 8.x (the F43 spec requires zip 5.x-7.x
# which is not available in the build tag).
# Remove this pin once Koji builders can see prior completed builds as deps.
# https://src.fedoraproject.org/rpms/rust-gix-archive/c/b435a6a075cdc705d25c60e17366c570e0880c08
[components.rust-gix-archive]
spec = { type = "upstream", upstream-commit = "b435a6a075cdc705d25c60e17366c570e0880c08" }
6 changes: 6 additions & 0 deletions base/comps/rust-schemars/rust-schemars.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Pin to commit that ships an in-sync version of rust-schemars_derive, avoiding a
# missing crate(schemars_derive/default) = 1.2.0 build failure.
# Remove this pin once Koji builders can see prior completed builds as deps.
# https://src.fedoraproject.org/rpms/rust-schemars/c/566b6f412bd5454682bdf8d15a33f1b5d4329418
[components.rust-schemars]
spec = { type = "upstream", upstream-commit = "566b6f412bd5454682bdf8d15a33f1b5d4329418" }
6 changes: 6 additions & 0 deletions base/comps/rust-zerocopy/rust-zerocopy.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Pin to commit that ships an in-sync version of rust-zerocopy-derive, avoiding a
# missing crate(zerocopy-derive/default) = 0.8.31 build failure.
# Remove this pin once Koji builders can see prior completed builds as deps.
# https://src.fedoraproject.org/rpms/rust-zerocopy/c/a093bbbabb313f5318b1d934e865edefcdb474ef
[components.rust-zerocopy]
spec = { type = "upstream", upstream-commit = "a093bbbabb313f5318b1d934e865edefcdb474ef" }
5 changes: 5 additions & 0 deletions base/comps/trustee-guest-components/trustee-guest-components.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Pin to older commit to avoid missing crate(canon-json) and crate(kbs-types) deps
# which are not available in the build tag at the latest F43 version.
# https://src.fedoraproject.org/rpms/trustee-guest-components/c/7ac284fd661640027d26cbe0711072c1c835f28e
[components.trustee-guest-components]
spec = { type = "upstream", upstream-commit = "7ac284fd661640027d26cbe0711072c1c835f28e" }
4 changes: 4 additions & 0 deletions base/comps/uv/uv.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Pin to 0.10.12 to avoid missing crate(astral-tokio-tar/default) build dependency.
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says “Pin to 0.10.12” but the configuration actually pins an upstream commit hash. To avoid confusion during future unpinning/debugging, update the comment to explicitly tie the commit to the corresponding version (e.g., mention both the commit and the uv version it represents), or reword it to say the pin is to that specific commit.

Suggested change
# Pin to 0.10.12 to avoid missing crate(astral-tokio-tar/default) build dependency.
# Pin upstream commit 07f74430e59fb84e925e6d7b238f0b334a42c97c (uv 0.10.12)
# to avoid missing crate(astral-tokio-tar/default) build dependency.

Copilot uses AI. Check for mistakes.
# https://src.fedoraproject.org/rpms/uv/c/07f74430e59fb84e925e6d7b238f0b334a42c97c
[components.uv]
spec = { type = "upstream", upstream-commit = "07f74430e59fb84e925e6d7b238f0b334a42c97c" }
Loading