fix: rust-servo_arc0.3: pin to Fedora 43 build commit baeff0cac3a5#16397
fix: rust-servo_arc0.3: pin to Fedora 43 build commit baeff0cac3a5#16397binujp wants to merge 1 commit intotomls/base/mainfrom
Conversation
Pin rust-servo_arc0.3 to upstream commit baeff0cac3a538d99181420a129a2fec49033ec6 (Fedora dist-git: rust-servo_arc) to fetch sources from the commit used to build the current f43 package.
There was a problem hiding this comment.
Pull request overview
Pins the rust-servo_arc0.3 component to the exact Fedora 43 dist-git commit used for the current Fedora build, ensuring source retrieval matches the buildroot provenance while keeping the rest of the distro on the normal Fedora snapshot flow.
Changes:
- Add a dedicated
rust-servo_arc0.3.comp.tomlthat pins the component to Fedora 43 commitbaeff0cac3a538d99181420a129a2fec49033ec6. - Remove the now-dedicated component entry from
components-full.tomlto avoid duplicate/empty definitions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| base/comps/rust-servo_arc0.3/rust-servo_arc0.3.comp.toml | Introduces an upstream spec pin (Fedora 43 + specific dist-git commit) with TODO for later removal. |
| base/comps/components-full.toml | Drops the inline component stub now that a dedicated *.comp.toml exists. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [components.'rust-servo_arc0.3'] | ||
| # Pin to the f43 commit used to build the current Fedora 43 package. | ||
| # TODO: Drop this override once the default Fedora 43 snapshot | ||
| # in distro/azurelinux.distro.toml advances past this commit. |
There was a problem hiding this comment.
The pin comment should include a full reference URL to the Fedora dist-git commit being pinned (for traceability and future cleanup), consistent with the repo’s comp-toml references guidance and existing examples (e.g., base/comps/golang/golang.comp.toml includes a “Fedora commit:” link). Consider adding a “Fedora commit: https://src.fedoraproject.org/rpms/rust-servo_arc/c/baeff0cac3a538d99181420a129a2fec49033ec6?branch=f43” line above the spec pin.
| # in distro/azurelinux.distro.toml advances past this commit. | |
| # in distro/azurelinux.distro.toml advances past this commit. | |
| # Fedora commit: https://src.fedoraproject.org/rpms/rust-servo_arc/c/baeff0cac3a538d99181420a129a2fec49033ec6?branch=f43 |
Pin rust-servo_arc0.3 to upstream commit baeff0cac3a538d99181420a129a2fec49033ec6 (Fedora dist-git: rust-servo_arc) to fetch sources from the commit used to build the current f43 package.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology