Skip to content

fix: rust-servo_arc0.3: pin to Fedora 43 build commit baeff0cac3a5#16397

Open
binujp wants to merge 1 commit intotomls/base/mainfrom
tomls/base/rust-servo_arc0.3
Open

fix: rust-servo_arc0.3: pin to Fedora 43 build commit baeff0cac3a5#16397
binujp wants to merge 1 commit intotomls/base/mainfrom
tomls/base/rust-servo_arc0.3

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented Mar 31, 2026

Pin rust-servo_arc0.3 to upstream commit baeff0cac3a538d99181420a129a2fec49033ec6 (Fedora dist-git: rust-servo_arc) to fetch sources from the commit used to build the current f43 package.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

Pin rust-servo_arc0.3 to upstream commit baeff0cac3a538d99181420a129a2fec49033ec6
(Fedora dist-git: rust-servo_arc) to fetch sources from the commit
used to build the current f43 package.
Copilot AI review requested due to automatic review settings March 31, 2026 22:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the rust-servo_arc0.3 component to the exact Fedora 43 dist-git commit used for the current Fedora build, ensuring source retrieval matches the buildroot provenance while keeping the rest of the distro on the normal Fedora snapshot flow.

Changes:

  • Add a dedicated rust-servo_arc0.3.comp.toml that pins the component to Fedora 43 commit baeff0cac3a538d99181420a129a2fec49033ec6.
  • Remove the now-dedicated component entry from components-full.toml to avoid duplicate/empty definitions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
base/comps/rust-servo_arc0.3/rust-servo_arc0.3.comp.toml Introduces an upstream spec pin (Fedora 43 + specific dist-git commit) with TODO for later removal.
base/comps/components-full.toml Drops the inline component stub now that a dedicated *.comp.toml exists.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[components.'rust-servo_arc0.3']
# Pin to the f43 commit used to build the current Fedora 43 package.
# TODO: Drop this override once the default Fedora 43 snapshot
# in distro/azurelinux.distro.toml advances past this commit.
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pin comment should include a full reference URL to the Fedora dist-git commit being pinned (for traceability and future cleanup), consistent with the repo’s comp-toml references guidance and existing examples (e.g., base/comps/golang/golang.comp.toml includes a “Fedora commit:” link). Consider adding a “Fedora commit: https://src.fedoraproject.org/rpms/rust-servo_arc/c/baeff0cac3a538d99181420a129a2fec49033ec6?branch=f43” line above the spec pin.

Suggested change
# in distro/azurelinux.distro.toml advances past this commit.
# in distro/azurelinux.distro.toml advances past this commit.
# Fedora commit: https://src.fedoraproject.org/rpms/rust-servo_arc/c/baeff0cac3a538d99181420a129a2fec49033ec6?branch=f43

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants