fix: rust-nalgebra0.33: pin to Fedora 43 build commit e6aed4cbdde8#16396
fix: rust-nalgebra0.33: pin to Fedora 43 build commit e6aed4cbdde8#16396binujp wants to merge 1 commit intotomls/base/mainfrom
Conversation
Pin rust-nalgebra0.33 to upstream commit e6aed4cbdde84e45e7cc3f0648d88575e041f8b2 (Fedora dist-git: rust-nalgebra) to fetch sources from the commit used to build the current f43 package.
There was a problem hiding this comment.
Pull request overview
Pins rust-nalgebra0.33 to a specific Fedora 43 dist-git commit so the component sources match the commit used for the current Fedora 43 build, and moves the component definition into a dedicated *.comp.toml file (removing the placeholder entry from the generated component list).
Changes:
- Added a dedicated component definition for
rust-nalgebra0.33that pinsspec.upstream-committoe6aed4cbdde84e45e7cc3f0648d88575e041f8b2. - Removed the
rust-nalgebra0.33entry fromcomponents-full.tomlnow that it has a dedicated file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| base/comps/rust-nalgebra0.33/rust-nalgebra0.33.comp.toml | Introduces an upstream-commit pin for Fedora 43 to ensure consistent sources for rust-nalgebra0.33. |
| base/comps/components-full.toml | Drops the now-redundant component stub entry after introducing a dedicated component file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [components.'rust-nalgebra0.33'] | ||
| # Pin to the f43 commit used to build the current Fedora 43 package. | ||
| # TODO: Drop this override once the default Fedora 43 snapshot | ||
| # in distro/azurelinux.distro.toml advances past this commit. |
There was a problem hiding this comment.
The pin comment should include a full reference URL to the Fedora dist-git commit being pinned (consistent with other upstream-commit pins, e.g. golang). Please add the https://src.fedoraproject.org/rpms/rust-nalgebra/c/?branch=f43 link (or equivalent) above the spec line so future readers can quickly verify the pin source and drop condition.
| # in distro/azurelinux.distro.toml advances past this commit. | |
| # in distro/azurelinux.distro.toml advances past this commit. | |
| # Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-nalgebra/c/e6aed4cbdde84e45e7cc3f0648d88575e041f8b2?branch=f43 |
Pin rust-nalgebra0.33 to upstream commit e6aed4cbdde84e45e7cc3f0648d88575e041f8b2 (Fedora dist-git: rust-nalgebra) to fetch sources from the commit used to build the current f43 package.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology