fix: rootlesskit: pin to Fedora 43 build commit eb6bc70fe34c#16395
fix: rootlesskit: pin to Fedora 43 build commit eb6bc70fe34c#16395christopherco merged 1 commit intotomls/base/mainfrom
Conversation
Pin rootlesskit to upstream commit eb6bc70fe34cb6947bb1fb1b61b23e34159273e7 (Fedora dist-git: golang-github-rootless-containers-rootlesskit) to fetch sources from the commit used to build the current f43 package.
There was a problem hiding this comment.
Pull request overview
Pins the rootlesskit component to a specific Fedora 43 dist-git commit so Azure Linux fetches the same sources as the currently built Fedora 43 package, while moving the component definition to a dedicated *.comp.toml file.
Changes:
- Added
base/comps/rootlesskit/rootlesskit.comp.tomlwith an upstream Fedora 43 commit pin forrootlesskit. - Removed the now-redundant
[components.rootlesskit]entry frombase/comps/components-full.toml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| base/comps/rootlesskit/rootlesskit.comp.toml | Introduces an upstream-commit pin for Fedora 43’s golang-github-rootless-containers-rootlesskit dist-git history. |
| base/comps/components-full.toml | Removes rootlesskit from the generated component list now that it has a dedicated component file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,5 @@ | |||
| [components.rootlesskit] | |||
| # Pin to the f43 commit used to build the current Fedora 43 package. | |||
There was a problem hiding this comment.
The pin rationale is clear, but per the repo’s comp.toml guidance, pins to an upstream commit should include a full reference URL to the external source commit (e.g., the Fedora dist-git commit URL with the f43 branch) so future maintainers can quickly verify and remove the override when appropriate.
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Fedora dist-git commit: https://src.fedoraproject.org/rpms/golang-github-rootless-containers-rootlesskit/c/eb6bc70fe34cb6947bb1fb1b61b23e34159273e7?branch=f43 |
Pin rootlesskit to upstream commit eb6bc70fe34cb6947bb1fb1b61b23e34159273e7 (Fedora dist-git: golang-github-rootless-containers-rootlesskit) to fetch sources from the commit used to build the current f43 package.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology