Skip to content

fix: rust-cssparser0.31: pin to Fedora 43 build commit b6fd5d766320#16393

Merged
christopherco merged 1 commit intotomls/base/mainfrom
tomls/base/rust-cssparser0.31
Apr 1, 2026
Merged

fix: rust-cssparser0.31: pin to Fedora 43 build commit b6fd5d766320#16393
christopherco merged 1 commit intotomls/base/mainfrom
tomls/base/rust-cssparser0.31

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented Mar 31, 2026

Pin rust-cssparser0.31 to upstream commit b6fd5d76632012a8ceb9119dac4f18711fde3fb4 (Fedora dist-git: rust-cssparser) to fetch sources from the commit used to build the current f43 package.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

Pin rust-cssparser0.31 to upstream commit b6fd5d76632012a8ceb9119dac4f18711fde3fb4
(Fedora dist-git: rust-cssparser) to fetch sources from the commit
used to build the current f43 package.
Copilot AI review requested due to automatic review settings March 31, 2026 22:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the rust-cssparser0.31 component to a specific Fedora 43 dist-git commit so Azure Linux fetches the exact spec/sources used for the current Fedora 43 build, while keeping component registration consistent with the repo’s dedicated *.comp.toml pattern.

Changes:

  • Added a dedicated rust-cssparser0.31.comp.toml defining an upstream spec pin to Fedora 43 commit b6fd5d76632012a8ceb9119dac4f18711fde3fb4.
  • Removed the now-redundant empty rust-cssparser0.31 entry from components-full.toml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
base/comps/rust-cssparser0.31/rust-cssparser0.31.comp.toml Introduces the Fedora 43 upstream commit pin for rust-cssparser0.31.
base/comps/components-full.toml Removes the old bare component entry now that a dedicated comp file exists.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,5 @@
[components.'rust-cssparser0.31']
# Pin to the f43 commit used to build the current Fedora 43 package.
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pin comment should include a direct reference URL to the Fedora dist-git commit being pinned (consistent with other upstream-commit pins, e.g. base/comps/golang/golang.comp.toml). This makes it easier to audit what’s being tracked and when it’s safe to remove the override.

Suggested change
# Pin to the f43 commit used to build the current Fedora 43 package.
# Pin to the f43 commit used to build the current Fedora 43 package.
# Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-cssparser/c/b6fd5d76632012a8ceb9119dac4f18711fde3fb4

Copilot uses AI. Check for mistakes.
# Pin to the f43 commit used to build the current Fedora 43 package.
# TODO: Drop this override once the default Fedora 43 snapshot
# in distro/azurelinux.distro.toml advances past this commit.
spec = { type = "upstream", upstream-name = "rust-cssparser", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "b6fd5d76632012a8ceb9119dac4f18711fde3fb4" }
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream-name = "rust-cssparser" makes the rust-cssparser0.31 component pull the same Fedora dist-git package as the existing [components.rust-cssparser] entry, which is likely to produce duplicate/conflicting RPM outputs and is inconsistent with how other version-suffixed Rust crate components map to Fedora. Unless Fedora’s dist-git for this component is actually named rust-cssparser (and not rust-cssparser0.31), the safer fix is to drop upstream-name so the upstream package name matches the component name; if the mismatch is intentional, it needs a clear comment + reference and a plan to avoid output collisions with rust-cssparser.

Suggested change
spec = { type = "upstream", upstream-name = "rust-cssparser", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "b6fd5d76632012a8ceb9119dac4f18711fde3fb4" }
spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "b6fd5d76632012a8ceb9119dac4f18711fde3fb4" }

Copilot uses AI. Check for mistakes.
@christopherco christopherco merged commit 8651996 into tomls/base/main Apr 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants