fix: rust-quick-xml0.38: pin to Fedora 43 build commit 592f13a068e5#16391
Merged
christopherco merged 1 commit intotomls/base/mainfrom Apr 1, 2026
Merged
fix: rust-quick-xml0.38: pin to Fedora 43 build commit 592f13a068e5#16391christopherco merged 1 commit intotomls/base/mainfrom
christopherco merged 1 commit intotomls/base/mainfrom
Conversation
Pin rust-quick-xml0.38 to upstream commit 592f13a068e585f78e5a3a1c5277eb9a7ed47cfd (Fedora dist-git: rust-quick-xml) to fetch sources from the commit used to build the current f43 package.
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the rust-quick-xml0.38 component to a specific Fedora 43 dist-git commit so azldev fetches the exact spec/sources used for the current Fedora 43 build, improving reproducibility while the default Fedora 43 snapshot lags behind.
Changes:
- Added a dedicated
rust-quick-xml0.38.comp.tomlwithspec.upstream-commitpinned to592f13a068e585f78e5a3a1c5277eb9a7ed47cfd. - Removed the now-redundant empty component entry from
components-full.toml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| base/comps/rust-quick-xml0.38/rust-quick-xml0.38.comp.toml | Adds an upstream commit pin for Fedora 43 to ensure deterministic spec/source selection. |
| base/comps/components-full.toml | Removes the empty rust-quick-xml0.38 entry since it now has a dedicated component file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [components.'rust-quick-xml0.38'] | ||
| # Pin to the f43 commit used to build the current Fedora 43 package. | ||
| # TODO: Drop this override once the default Fedora 43 snapshot | ||
| # in distro/azurelinux.distro.toml advances past this commit. |
There was a problem hiding this comment.
The pin comment should include a full reference URL to the Fedora dist-git commit being pinned (consistent with other upstream-commit pins). This makes it easy to audit/compare against Fedora and later decide when to drop the override.
Suggested change
| # in distro/azurelinux.distro.toml advances past this commit. | |
| # in distro/azurelinux.distro.toml advances past this commit. | |
| # Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-quick-xml/c/592f13a068e585f78e5a3a1c5277eb9a7ed47cfd |
christopherco
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin rust-quick-xml0.38 to upstream commit 592f13a068e585f78e5a3a1c5277eb9a7ed47cfd (Fedora dist-git: rust-quick-xml) to fetch sources from the commit used to build the current f43 package.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology